Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: components/metrics/histogram_manager.h

Issue 1075503002: Move histogram_manager from components/metrics to components/cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Raman's comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/BUILD.gn ('k') | components/metrics/histogram_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/histogram_manager.h
diff --git a/components/metrics/histogram_manager.h b/components/metrics/histogram_manager.h
deleted file mode 100644
index 7334ae35f29a0305efdb6fc5d85b3288fdbd73fa..0000000000000000000000000000000000000000
--- a/components/metrics/histogram_manager.h
+++ /dev/null
@@ -1,62 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef COMPONENTS_METRICS_HISTOGRAM_MANAGER_H_
-#define COMPONENTS_METRICS_HISTOGRAM_MANAGER_H_
-
-#include <string>
-#include <vector>
-
-#include "base/basictypes.h"
-#include "base/lazy_instance.h"
-#include "base/macros.h"
-#include "base/memory/scoped_ptr.h"
-#include "base/metrics/histogram_flattener.h"
-#include "base/metrics/histogram_snapshot_manager.h"
-#include "components/metrics/proto/chrome_user_metrics_extension.pb.h"
-
-namespace metrics {
-
-// TODO(mef): crbug.com/441441. Move components/metrics/histogram_manager.*
-// files into components/android/cronet.
-//
-// A HistogramManager instance is created by Android. It is the central
-// controller for the acquisition of log data, and the automatic transmission of
-// that log data to an external server.
-class HistogramManager : public base::HistogramFlattener {
- public:
- HistogramManager();
- ~HistogramManager() override;
-
- // Snapshot all histograms to record the delta into |uma_proto_| and then
- // returns the serialized protobuf representation of the record in |data|.
- // Returns true if it was successfully serialized.
- bool GetDeltas(std::vector<uint8>* data);
-
- // TODO(mef): Hang Histogram Manager off java object instead of singleton.
- static HistogramManager* GetInstance();
-
- private:
- friend struct base::DefaultLazyInstanceTraits<HistogramManager>;
-
- // base::HistogramFlattener:
- void RecordDelta(const base::HistogramBase& histogram,
- const base::HistogramSamples& snapshot) override;
- void InconsistencyDetected(
- base::HistogramBase::Inconsistency problem) override;
- void UniqueInconsistencyDetected(
- base::HistogramBase::Inconsistency problem) override;
- void InconsistencyDetectedInLoggedCount(int amount) override;
-
- base::HistogramSnapshotManager histogram_snapshot_manager_;
-
- // Stores the protocol buffer representation for this log.
- metrics::ChromeUserMetricsExtension uma_proto_;
-
- DISALLOW_COPY_AND_ASSIGN(HistogramManager);
-};
-
-} // namespace metrics
-
-#endif // COMPONENTS_METRICS_HISTOGRAM_MANAGER_H_
« no previous file with comments | « components/metrics/BUILD.gn ('k') | components/metrics/histogram_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698