Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: components/cronet/histogram_manager_unittest.cc

Issue 1075503002: Move histogram_manager from components/metrics to components/cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/metrics/histogram_manager.h" 5 #include "components/cronet/histogram_manager.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/metrics/statistics_recorder.h"
10 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
11 12
12 namespace metrics { 13 namespace cronet {
13 14
14 // TODO(mef): crbug.com/441441. Move components/metrics/histogram_manager.* 15 using metrics::ChromeUserMetricsExtension;
15 // files into components/android/cronet. 16 using metrics::HistogramEventProto;
17
16 // TODO(rtenneti): enable flaky HistogramBucketFields unit test. 18 // TODO(rtenneti): enable flaky HistogramBucketFields unit test.
ramant (doing other things) 2015/04/09 00:10:22 nit: Would appreciate if you could delete the TODO
mef 2015/04/09 00:41:40 Done.
17 TEST(HistogramManager, DISABLED_HistogramBucketFields) { 19 TEST(HistogramManager, HistogramBucketFields) {
20 base::StatisticsRecorder::Initialize();
18 // Capture histograms at the start of the test to avoid later GetDeltas() 21 // Capture histograms at the start of the test to avoid later GetDeltas()
19 // calls picking them up. 22 // calls picking them up.
20 std::vector<uint8> data_init; 23 std::vector<uint8> data_init;
21 HistogramManager::GetInstance()->GetDeltas(&data_init); 24 HistogramManager::GetInstance()->GetDeltas(&data_init);
22 25
23 // kNoFlags filter should record all histograms. 26 // kNoFlags filter should record all histograms.
24 UMA_HISTOGRAM_ENUMERATION("UmaHistogramManager", 1, 2); 27 UMA_HISTOGRAM_ENUMERATION("UmaHistogramManager", 1, 2);
25 28
26 std::vector<uint8> data; 29 std::vector<uint8> data;
27 EXPECT_TRUE(HistogramManager::GetInstance()->GetDeltas(&data)); 30 EXPECT_TRUE(HistogramManager::GetInstance()->GetDeltas(&data));
(...skipping 20 matching lines...) Expand all
48 EXPECT_FALSE(data2.empty()); 51 EXPECT_FALSE(data2.empty());
49 52
50 const HistogramEventProto& histogram_proto2 = 53 const HistogramEventProto& histogram_proto2 =
51 uma_proto2.histogram_event(uma_proto2.histogram_event_size() - 1); 54 uma_proto2.histogram_event(uma_proto2.histogram_event_size() - 1);
52 ASSERT_EQ(1, histogram_proto2.bucket_size()); 55 ASSERT_EQ(1, histogram_proto2.bucket_size());
53 EXPECT_LE(0, histogram_proto2.bucket(0).min()); 56 EXPECT_LE(0, histogram_proto2.bucket(0).min());
54 EXPECT_LE(3, histogram_proto2.bucket(0).max()); 57 EXPECT_LE(3, histogram_proto2.bucket(0).max());
55 EXPECT_EQ(1, histogram_proto2.bucket(0).count()); 58 EXPECT_EQ(1, histogram_proto2.bucket(0).count());
56 } 59 }
57 60
58 } // namespace metrics 61 } // namespace cronet
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698