Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1075443004: Rename from ERROR_AUDIO to ERROR_AUDIO_CAPTURE (Closed)

Created:
5 years, 8 months ago by deejay
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename from ERROR_AUDIO to ERROR_AUDIO_CAPTURE Spec draft proposal : https://dvcs.w3.org/hg/speech-api/raw-file/tip/webspeechapi.html#speechreco-error Some attributes of SpeechRecognitionError are not same as latest specification. We need to change from "SPEECH_RECOGNITION_ERROR_AUDIO" to "SPEECH_RECOGNITION_ERROR_AUDIO_CAPTURE" BUG=116954 Committed: https://crrev.com/a8a4009ea03e82c14ba8a4fdeab4291b9c2cab56 Cr-Commit-Position: refs/heads/master@{#326471}

Patch Set 1 #

Patch Set 2 : Rebased with lastest commit #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M content/browser/speech/google_streaming_remote_engine.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_recognizer_impl.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M content/browser/speech/speech_recognizer_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/SpeechRecognition.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/speech_recognition_error.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/speech_recognition_dispatcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (8 generated)
deejay
Dear hans, tommi. Please take a look this patch
5 years, 8 months ago (2015-04-10 15:49:41 UTC) #2
deejay
+ add more reviewer. Dear dmazzoni, dtseng. Is it possible to review about patch for ...
5 years, 8 months ago (2015-04-13 15:54:03 UTC) #4
deejay
On 2015/04/13 15:54:03, deejay wrote: > + add more reviewer. > > Dear dmazzoni, dtseng. ...
5 years, 8 months ago (2015-04-20 14:41:52 UTC) #5
tommi (sloooow) - chröme
lgtm
5 years, 8 months ago (2015-04-20 16:18:30 UTC) #6
gshires1
lgtm
5 years, 8 months ago (2015-04-20 20:17:20 UTC) #7
deejay
On 2015/04/20 20:17:20, gshires1 wrote: > lgtm Dear, Charlie Reis, David Benjamin. Could you review ...
5 years, 8 months ago (2015-04-21 06:26:31 UTC) #9
Charlie Reis
This is just code cleanup with no functional change, right? LGTM. Same nit about the ...
5 years, 8 months ago (2015-04-21 17:06:50 UTC) #10
deejay
On 2015/04/21 17:06:50, Charlie Reis wrote: > This is just code cleanup with no functional ...
5 years, 8 months ago (2015-04-23 00:57:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075443004/20001
5 years, 8 months ago (2015-04-23 00:59:08 UTC) #14
hans
On 2015/04/23 00:57:54, deejay wrote: > On 2015/04/21 17:06:50, Charlie Reis wrote: > > This ...
5 years, 8 months ago (2015-04-23 00:59:43 UTC) #15
deejay
On 2015/04/23 00:59:43, hans wrote: > On 2015/04/23 00:57:54, deejay wrote: > > On 2015/04/21 ...
5 years, 8 months ago (2015-04-23 02:02:39 UTC) #17
hans
On 2015/04/23 02:02:39, deejay wrote: > I've updated BUG id. Great, thanks! Looking at the ...
5 years, 8 months ago (2015-04-23 02:28:49 UTC) #18
deejay
On 2015/04/23 02:28:49, hans wrote: > On 2015/04/23 02:02:39, deejay wrote: > > I've updated ...
5 years, 8 months ago (2015-04-23 05:46:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075443004/40001
5 years, 8 months ago (2015-04-23 05:47:46 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-23 07:33:52 UTC) #23
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 07:34:51 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a8a4009ea03e82c14ba8a4fdeab4291b9c2cab56
Cr-Commit-Position: refs/heads/master@{#326471}

Powered by Google App Engine
This is Rietveld 408576698