Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1075303003: PPC: [turbofan] Load immortal heap objects from the heap roots. (Closed)

Created:
5 years, 8 months ago by MTBrandyberry
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Load immortal heap objects from the heap roots. Port 5d2de78a771b8ff1ac59fbdf634bffd01709b554 Original commit message: It's cheaper to materialize heap constants by loading from the roots array instead of embedding the constant into the instruction stream, at least on x64, arm and arm64. Drive-by-fix: Also cleanup the materialize constant from frame optimization. R=michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/8ad33d6db6de581c71a9668158910eaaccdce1dd Cr-Commit-Position: refs/heads/master@{#27823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +6 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
MTBrandyberry
Port optimization to PPC.
5 years, 8 months ago (2015-04-14 14:36:14 UTC) #1
michael_dawson
On 2015/04/14 14:36:14, mtbrandyberry wrote: > Port optimization to PPC. lgtm.
5 years, 8 months ago (2015-04-14 14:51:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075303003/1
5 years, 8 months ago (2015-04-14 14:53:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 15:17:33 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 15:17:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ad33d6db6de581c71a9668158910eaaccdce1dd
Cr-Commit-Position: refs/heads/master@{#27823}

Powered by Google App Engine
This is Rietveld 408576698