chrome/browser/signin/chrome_signin_client.cc - Issue 1075273002: Handle ListAccount fetches from within the GaiaCookieManagerService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/chrome_signin_client.cc

Issue 1075273002: Handle ListAccount fetches from within the GaiaCookieManagerService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/signin/account_reconcilor_unittest.cc ('k') | chrome/browser/signin/fake_account_reconcilor.h » ('j') | google_apis/gaia/gaia_switches.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/chrome_signin_client.cc

diff --git a/chrome/browser/signin/chrome_signin_client.cc b/chrome/browser/signin/chrome_signin_client.cc

index debf8eca4de39a1bea92bde43c12001b0a21a36a..90ddd80421e1c06e4069745008ded78fe1377616 100644

--- a/chrome/browser/signin/chrome_signin_client.cc

+++ b/chrome/browser/signin/chrome_signin_client.cc

@@ -61,8 +61,10 @@ bool ChromeSigninClient::ProfileAllowsSigninCookies(Profile* profile) {

bool ChromeSigninClient::SettingsAllowSigninCookies(

CookieSettings* cookie_settings) {

GURL gaia_url = GaiaUrls::GetInstance()->gaia_url();

+ GURL google_url = GaiaUrls::GetInstance()->google_url();

return cookie_settings &&

- cookie_settings->IsSettingCookieAllowed(gaia_url, gaia_url);

+ cookie_settings->IsSettingCookieAllowed(gaia_url, gaia_url) &&

+ cookie_settings->IsSettingCookieAllowed(google_url, google_url);

Roger Tawa OOO till Jul 10th 2015/04/21 13:46:36 With this change, |google_url| now has the protoco

Mike Lerman 2015/04/21 15:16:16 Yes - the APISID cookie is http:// not https://.

}

PrefService* ChromeSigninClient::GetPrefs() { return profile_->GetPrefs(); }