tools/run_perf.py - Issue 1075143002: Add perf test configuration to track memory use of context and isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/run_perf.py

Issue 1075143002: Add perf test configuration to track memory use of context and isolate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/run_perf.py

diff --git a/tools/run_perf.py b/tools/run_perf.py

index f7710796bc3e7c651e4effcae031e1fd95eec129..46269f392ab8b5223977632a81ab51ee930c8fd6 100755

--- a/tools/run_perf.py

+++ b/tools/run_perf.py

@@ -411,8 +411,8 @@ def MakeGraph(suite, arch, parent):

if isinstance(parent, Runnable):

# Below a runnable can only be traces.

return Trace(suite, parent, arch)

- elif suite.get("main"):

- # A main file makes this graph runnable.

+ elif suite.get("main") != None:

Michael Achenbach 2015/04/10 09:09:47 is not None

+ # A main file makes this graph runnable. Empty strings are accepted.

if suite.get("tests"):

# This graph has subgraphs (traces).

return Runnable(suite, parent, arch)

« no previous file with comments | « test/memory/Memory.json ('k') | no next file » | no next file with comments »