Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1075133002: Special case the "empty string" root so it doesn't constantly jump around (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Special case the "empty string" root so it doesn't constantly jump around BUG=none R=hpayer@chromium.org LOG=n Committed: https://crrev.com/f56fb72f984a212e698c27799b5d10b9aace59db Cr-Commit-Position: refs/heads/master@{#27736}

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 3 chunks +2 lines, -1 line 1 comment Download
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-10 08:30:58 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 8 months ago (2015-04-10 08:49:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075133002/20001
5 years, 8 months ago (2015-04-10 09:07:33 UTC) #4
Yang
https://codereview.chromium.org/1075133002/diff/20001/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1075133002/diff/20001/src/heap/heap.h#newcode63 src/heap/heap.h:63: /* The roots above this line should be boring ...
5 years, 8 months ago (2015-04-10 09:23:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-10 09:23:49 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 09:24:03 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f56fb72f984a212e698c27799b5d10b9aace59db
Cr-Commit-Position: refs/heads/master@{#27736}

Powered by Google App Engine
This is Rietveld 408576698