Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1075103002: [x86] Support immediate indices for StoreWriteBarrier. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x86] Support immediate indices for StoreWriteBarrier. Ideally we would not need the StoreWriteBarrier instructions at all, but represent the RecordWrite functionality as machine subgraph, but that'll take some time to get there. In the mean time we can have a shorter instruction sequence on Intel platforms by recognizing immediate indices here. R=svenpanne@chromium.org Committed: https://crrev.com/4eff883bcecaf24dfdcc6441e4558a9f5e69bd55 Cr-Commit-Position: refs/heads/master@{#27731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -19 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +11 lines, -5 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-10 05:50:46 UTC) #1
Benedikt Meurer
Hey Sven, This is more or less obvious. Don't be confused with the RecordWriteForContextSlot naming, ...
5 years, 8 months ago (2015-04-10 05:51:58 UTC) #2
Sven Panne
lgtm
5 years, 8 months ago (2015-04-10 06:01:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075103002/1
5 years, 8 months ago (2015-04-10 06:01:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 06:16:31 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 06:16:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4eff883bcecaf24dfdcc6441e4558a9f5e69bd55
Cr-Commit-Position: refs/heads/master@{#27731}

Powered by Google App Engine
This is Rietveld 408576698