New SELECT Popup: Fix window width to include scrollbar width

New SELECT Popup: Fix window width to include scrollbar width

We need to manually increase the window width for the scrollbar because setting overflow to auto doesn't increase the width automatically.

BUG=475005
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193751

[keishi, 2015-04-13 04:08:11]

keishi@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2015-04-13 04:34:17]

lgtm

https://codereview.chromium.org/1075073004/diff/1/Source/web/resources/listPi...
File Source/web/resources/listPicker.js (right):

https://codereview.chromium.org/1075073004/diff/1/Source/web/resources/listPi...
Source/web/resources/listPicker.js:192: if (!expectingScrollbar &&
windowRect.height < noScrollHeight) {
Can you add a test for this condition?
If it's hard, you may add it later.

[keishi, 2015-04-13 04:38:46]

https://codereview.chromium.org/1075073004/diff/1/Source/web/resources/listPi...
File Source/web/resources/listPicker.js (right):

https://codereview.chromium.org/1075073004/diff/1/Source/web/resources/listPi...
Source/web/resources/listPicker.js:192: if (!expectingScrollbar &&
windowRect.height < noScrollHeight) {
On 2015/04/13 04:34:16, tkent wrote:
> Can you add a test for this condition?
> If it's hard, you may add it later.

Done. LayoutTests/fast/forms/select/popup-menu-appearance-tall.html

[keishi, 2015-04-13 04:38:46]

https://codereview.chromium.org/1075073004/diff/1/Source/web/resources/listPi...
File Source/web/resources/listPicker.js (right):

https://codereview.chromium.org/1075073004/diff/1/Source/web/resources/listPi...
Source/web/resources/listPicker.js:192: if (!expectingScrollbar &&
windowRect.height < noScrollHeight) {
On 2015/04/13 04:34:16, tkent wrote:
> Can you add a test for this condition?
> If it's hard, you may add it later.

Done. LayoutTests/fast/forms/select/popup-menu-appearance-tall.html

[tkent, 2015-04-13 04:42:11]

lgtm

> > Can you add a test for this condition?
> > If it's hard, you may add it later.
> 
> Done. LayoutTests/fast/forms/select/popup-menu-appearance-tall.html

Wow, too quick!

[tkent, 2015-04-13 04:42:14]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-04-13 04:42:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1075073004/40001

[commit-bot: I haz the power, 2015-04-13 04:46:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-13 04:46:31]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)

[keishi, 2015-04-13 10:43:31]

The CQ bit was checked by keishi@chromium.org

[keishi, 2015-04-13 10:43:32]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1075073004/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2015-04-13 10:43:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1075073004/60001

[commit-bot: I haz the power, 2015-04-13 15:34:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-13 15:34:24]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[keishi, 2015-04-14 10:53:45]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2015-04-14 10:54:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1075073004/60001

[tkent, 2015-04-14 10:56:13]

On 2015/04/13 15:34:24, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_blink_rel on tryserver.blink (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

You need to add a virtual/slimmingpaint/ variant to TestExpectations.

[commit-bot: I haz the power, 2015-04-14 13:21:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 13:21:10]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[keishi, 2015-04-15 05:36:07]

The CQ bit was checked by keishi@chromium.org

[keishi, 2015-04-15 05:36:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1075073004/#ps80001
(title: "Added TestExpectation entry")

[commit-bot: I haz the power, 2015-04-15 05:36:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1075073004/80001

[commit-bot: I haz the power, 2015-04-15 06:23:35]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193751