Issue 1075033002: [Android] Fix provisioning for non-rooted devices.

Issue 1075033002: [Android] Fix provisioning for non-rooted devices. (Closed)

Created:
5 years, 8 months ago by jbudorick

Modified:
5 years, 8 months ago

Reviewers:
navabi1, navabi

CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[Android] Fix provisioning for non-rooted devices. I broke provisioning on non-rooted devices in https://codereview.chromium.org/1060943002/. This fixes it by making exceptions thrown by commands requiring root access nonfatal. BUG= Committed: https://crrev.com/9e8fa5da201e72dd60333cf16a2ecb72f9d1ca3c Cr-Commit-Position: refs/heads/master@{#324538}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -44 lines)			Patch
	M	build/android/provision_devices.py	View		3 chunks	+45 lines, -44 lines	0 comments	Download

Total messages: 8 (2 generated)

jbudorick

the diff makes it look like more than just moving try/excepts around

5 years, 8 months ago (2015-04-09 22:14:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1075033002/1

5 years, 8 months ago (2015-04-09 23:03:33 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-09 23:44:20 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9e8fa5da201e72dd60333cf16a2ecb72f9d1ca3c
Cr-Commit-Position: refs/heads/master@{#324538}