Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/libplatform/default-platform.cc

Issue 107503005: Always terminate the task queue (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 27 matching lines...) Expand all
38 namespace v8 { 38 namespace v8 {
39 namespace internal { 39 namespace internal {
40 40
41 41
42 DefaultPlatform::DefaultPlatform() 42 DefaultPlatform::DefaultPlatform()
43 : initialized_(false), thread_pool_size_(0) {} 43 : initialized_(false), thread_pool_size_(0) {}
44 44
45 45
46 DefaultPlatform::~DefaultPlatform() { 46 DefaultPlatform::~DefaultPlatform() {
47 LockGuard<Mutex> guard(&lock_); 47 LockGuard<Mutex> guard(&lock_);
48 queue_.Terminate();
48 if (initialized_) { 49 if (initialized_) {
49 queue_.Terminate();
50 for (std::vector<WorkerThread*>::iterator i = thread_pool_.begin(); 50 for (std::vector<WorkerThread*>::iterator i = thread_pool_.begin();
51 i != thread_pool_.end(); ++i) { 51 i != thread_pool_.end(); ++i) {
52 delete *i; 52 delete *i;
53 } 53 }
54 } 54 }
55 } 55 }
56 56
57 57
58 void DefaultPlatform::SetThreadPoolSize(int thread_pool_size) { 58 void DefaultPlatform::SetThreadPoolSize(int thread_pool_size) {
59 LockGuard<Mutex> guard(&lock_); 59 LockGuard<Mutex> guard(&lock_);
(...skipping 20 matching lines...) Expand all
80 } 80 }
81 81
82 82
83 void DefaultPlatform::CallOnForegroundThread(v8::Isolate* isolate, Task* task) { 83 void DefaultPlatform::CallOnForegroundThread(v8::Isolate* isolate, Task* task) {
84 // TODO(jochen): implement. 84 // TODO(jochen): implement.
85 task->Run(); 85 task->Run();
86 delete task; 86 delete task;
87 } 87 }
88 88
89 } } // namespace v8::internal 89 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698