Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: regexp2000/src/regexp-macro-assembler.h

Issue 10750: * Update to RegExp parsing and AST. (Closed)
Patch Set: Addressed review comments Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « regexp2000/src/parser.cc ('k') | regexp2000/src/regexp-macro-assembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: regexp2000/src/regexp-macro-assembler.h
diff --git a/regexp2000/src/regexp-macro-assembler.h b/regexp2000/src/regexp-macro-assembler.h
index 6edd13e9699d9d17e09800d8e0c9aebdb5927616..aaf1c1ae7d624d786dde84429565944e148cacec 100644
--- a/regexp2000/src/regexp-macro-assembler.h
+++ b/regexp2000/src/regexp-macro-assembler.h
@@ -123,7 +123,7 @@ class RegExpMacroAssembler {
template <typename T>
struct ArraySlice {
-public:
+ public:
ArraySlice(Handle<ByteArray> array, size_t offset)
: array_(array), offset_(offset) {}
Handle<ByteArray> array() { return array_; }
@@ -139,15 +139,15 @@ public:
T& operator[](int idx) {
return reinterpret_cast<T*>(array_->GetDataStartAddress() + offset)[idx];
}
-private:
- const Handle<ByteArray> array_;
- const size_t offset_;
+ private:
+ Handle<ByteArray> array_;
+ size_t offset_;
};
class ByteArrayProvider {
public:
- ByteArrayProvider(int initial_size);
+ explicit ByteArrayProvider(int initial_size);
// Provides a place to put "size" elements of type T. The information
// can be stored in the provided ByteArray at the "offset". The offset is
// aligned to an "align"-boundary
« no previous file with comments | « regexp2000/src/parser.cc ('k') | regexp2000/src/regexp-macro-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698