media/cast/sender/video_encoder_impl.cc - Issue 1074963003: Clean up potentially leaky use of base::DeletePointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/sender/video_encoder_impl.cc

Issue 1074963003: Clean up potentially leaky use of base::DeletePointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed another probleb Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/cast/sender/video_encoder_impl.cc

diff --git a/media/cast/sender/video_encoder_impl.cc b/media/cast/sender/video_encoder_impl.cc

index 84f700e2cf9eb3edf7b47cf9822120504c81747f..d0703e93f2dd88d4cbda88517802446abeb89abf 100644

--- a/media/cast/sender/video_encoder_impl.cc

+++ b/media/cast/sender/video_encoder_impl.cc

@@ -103,7 +103,7 @@ VideoEncoderImpl::~VideoEncoderImpl() {

CastEnvironment::VIDEO,

FROM_HERE,

base::Bind(&base::DeletePointer<SoftwareVideoEncoder>,

- encoder_.release()));

+ base::Passed(&encoder_)));

}

« no previous file with comments | « media/audio/virtual_audio_output_stream_unittest.cc ('k') | ui/events/devices/device_data_manager.cc » ('j') | no next file with comments »