Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: media/audio/virtual_audio_input_stream_unittest.cc

Issue 1074963003: Clean up potentially leaky use of base::DeletePointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed another probleb Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/virtual_audio_input_stream.cc ('k') | media/audio/virtual_audio_output_stream_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/virtual_audio_input_stream_unittest.cc
diff --git a/media/audio/virtual_audio_input_stream_unittest.cc b/media/audio/virtual_audio_input_stream_unittest.cc
index 3ff07b8f41cd05d0dd122b4940edee3b85d93c05..51526574b3bb61e624155133e0b4df0f9ee5561a 100644
--- a/media/audio/virtual_audio_input_stream_unittest.cc
+++ b/media/audio/virtual_audio_input_stream_unittest.cc
@@ -87,6 +87,11 @@ class TestAudioSource : public SineWaveAudioSource {
} // namespace
+static void DeleteVirtualAudioOutputStream(
+ VirtualAudioOutputStream* audio_stream) {
+ delete audio_stream;
+}
+
class VirtualAudioInputStreamTest : public testing::TestWithParam<bool> {
public:
VirtualAudioInputStreamTest()
@@ -109,7 +114,7 @@ class VirtualAudioInputStreamTest : public testing::TestWithParam<bool> {
const bool worker_is_separate_thread = GetParam();
stream_ = new VirtualAudioInputStream(
kParams, GetWorkerTaskRunner(worker_is_separate_thread),
- base::Bind(&base::DeletePointer<VirtualAudioInputStream>));
+ true);
stream_->Open();
}
@@ -125,7 +130,7 @@ class VirtualAudioInputStreamTest : public testing::TestWithParam<bool> {
AudioOutputStream* const output_stream = new VirtualAudioOutputStream(
kParams,
stream_,
- base::Bind(&base::DeletePointer<VirtualAudioOutputStream>));
+ base::Bind(&DeleteVirtualAudioOutputStream));
output_streams_.push_back(output_stream);
output_stream->Open();
« no previous file with comments | « media/audio/virtual_audio_input_stream.cc ('k') | media/audio/virtual_audio_output_stream_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698