Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Unified Diff: media/audio/virtual_audio_input_stream.h

Issue 1074963003: Clean up potentially leaky use of base::DeletePointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed another probleb Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/mojo/async_handle_waiter.cc ('k') | media/audio/virtual_audio_input_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/virtual_audio_input_stream.h
diff --git a/media/audio/virtual_audio_input_stream.h b/media/audio/virtual_audio_input_stream.h
index d64ef359e96c6cfb5b14576132ffafa25be403d8..bef7fd2f3013128b0b5401f477ba7ccd8b0c9fb0 100644
--- a/media/audio/virtual_audio_input_stream.h
+++ b/media/audio/virtual_audio_input_stream.h
@@ -31,10 +31,6 @@ class VirtualAudioOutputStream;
// audio until this VirtualAudioInputStream is stopped and closed.
class MEDIA_EXPORT VirtualAudioInputStream : public AudioInputStream {
public:
- // Callback invoked just after VirtualAudioInputStream is closed.
- typedef base::Callback<void(VirtualAudioInputStream* vais)>
- AfterCloseCallback;
-
// Construct a target for audio loopback which mixes multiple data streams
// into a single stream having the given |params|. |worker_task_runner| is
// the task runner on which AudioInputCallback methods are called and may or
@@ -42,7 +38,7 @@ class MEDIA_EXPORT VirtualAudioInputStream : public AudioInputStream {
VirtualAudioInputStream(
const AudioParameters& params,
const scoped_refptr<base::SingleThreadTaskRunner>& worker_task_runner,
- const AfterCloseCallback& after_close_cb);
+ bool delete_on_close);
~VirtualAudioInputStream() override;
@@ -81,7 +77,7 @@ class MEDIA_EXPORT VirtualAudioInputStream : public AudioInputStream {
const scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner_;
- AfterCloseCallback after_close_cb_;
+ const bool delete_on_close_;
AudioInputCallback* callback_;
« no previous file with comments | « ipc/mojo/async_handle_waiter.cc ('k') | media/audio/virtual_audio_input_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698