device/hid/hid_service.h - Issue 1074963003: Clean up potentially leaky use of base::DeletePointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/hid/hid_service.h

Issue 1074963003: Clean up potentially leaky use of base::DeletePointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed another probleb Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/hid/hid_service.h

diff --git a/device/hid/hid_service.h b/device/hid/hid_service.h

index 6d6ef2bd2860fc18313652ae8d2c16c2296c9e50..d1c7ef448a4e9da6c9d2903989911090627fd8ee 100644

--- a/device/hid/hid_service.h

+++ b/device/hid/hid_service.h

@@ -61,7 +61,7 @@ class HidService {

const ConnectCallback& callback) = 0;

protected:

- friend void base::DeletePointer<HidService>(HidService* service);

+ friend struct base::DefaultDeleter<HidService>;

friend class HidConnectionTest;

typedef std::map<HidDeviceId, scoped_refptr<HidDeviceInfo>> DeviceMap;

« no previous file with comments | « device/core/device_monitor_win.cc ('k') | device/hid/hid_service.cc » ('j') | no next file with comments »