Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: media/audio/virtual_audio_output_stream_unittest.cc

Issue 1074963003: Clean up potentially leaky use of base::DeletePointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed another probleb Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/bind_helpers.h" 6 #include "base/bind_helpers.h"
7 #include "base/synchronization/waitable_event.h" 7 #include "base/synchronization/waitable_event.h"
8 #include "base/threading/thread.h" 8 #include "base/threading/thread.h"
9 #include "media/audio/audio_manager.h" 9 #include "media/audio/audio_manager.h"
10 #include "media/audio/simple_sources.h" 10 #include "media/audio/simple_sources.h"
11 #include "media/audio/virtual_audio_input_stream.h" 11 #include "media/audio/virtual_audio_input_stream.h"
12 #include "media/audio/virtual_audio_output_stream.h" 12 #include "media/audio/virtual_audio_output_stream.h"
13 #include "testing/gmock/include/gmock/gmock.h" 13 #include "testing/gmock/include/gmock/gmock.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 using ::testing::_; 16 using ::testing::_;
17 17
18 namespace media { 18 namespace media {
19 19
20 namespace { 20 namespace {
21 const AudioParameters kParams( 21 const AudioParameters kParams(
22 AudioParameters::AUDIO_PCM_LOW_LATENCY, CHANNEL_LAYOUT_MONO, 8000, 8, 128); 22 AudioParameters::AUDIO_PCM_LOW_LATENCY, CHANNEL_LAYOUT_MONO, 8000, 8, 128);
23 } 23 }
24 24
25 class MockVirtualAudioInputStream : public VirtualAudioInputStream { 25 class MockVirtualAudioInputStream : public VirtualAudioInputStream {
26 public: 26 public:
27 explicit MockVirtualAudioInputStream( 27 explicit MockVirtualAudioInputStream(
28 const scoped_refptr<base::SingleThreadTaskRunner>& worker_task_runner) 28 const scoped_refptr<base::SingleThreadTaskRunner>& worker_task_runner)
29 : VirtualAudioInputStream( 29 : VirtualAudioInputStream(kParams, worker_task_runner, true) {}
30 kParams,
31 worker_task_runner,
32 base::Bind(&base::DeletePointer<VirtualAudioInputStream>)) {}
33 ~MockVirtualAudioInputStream() {} 30 ~MockVirtualAudioInputStream() {}
34 31
35 MOCK_METHOD2(AddOutputStream, void(VirtualAudioOutputStream* stream, 32 MOCK_METHOD2(AddOutputStream, void(VirtualAudioOutputStream* stream,
36 const AudioParameters& output_params)); 33 const AudioParameters& output_params));
37 MOCK_METHOD2(RemoveOutputStream, void(VirtualAudioOutputStream* stream, 34 MOCK_METHOD2(RemoveOutputStream, void(VirtualAudioOutputStream* stream,
38 const AudioParameters& output_params)); 35 const AudioParameters& output_params));
39 36
40 private: 37 private:
41 DISALLOW_COPY_AND_ASSIGN(MockVirtualAudioInputStream); 38 DISALLOW_COPY_AND_ASSIGN(MockVirtualAudioInputStream);
42 }; 39 };
(...skipping 23 matching lines...) Expand all
66 done.Wait(); 63 done.Wait();
67 } 64 }
68 65
69 private: 66 private:
70 scoped_ptr<base::Thread> audio_thread_; 67 scoped_ptr<base::Thread> audio_thread_;
71 scoped_refptr<base::SingleThreadTaskRunner> audio_task_runner_; 68 scoped_refptr<base::SingleThreadTaskRunner> audio_task_runner_;
72 69
73 DISALLOW_COPY_AND_ASSIGN(VirtualAudioOutputStreamTest); 70 DISALLOW_COPY_AND_ASSIGN(VirtualAudioOutputStreamTest);
74 }; 71 };
75 72
73 static void DeleteVirtualAudioOutputStream(
74 VirtualAudioOutputStream* audio_stream) {
75 delete audio_stream;
76 }
77
76 TEST_F(VirtualAudioOutputStreamTest, StartStopStartStop) { 78 TEST_F(VirtualAudioOutputStreamTest, StartStopStartStop) {
77 static const int kCycles = 3; 79 static const int kCycles = 3;
78 80
79 MockVirtualAudioInputStream* const input_stream = 81 MockVirtualAudioInputStream* const input_stream =
80 new MockVirtualAudioInputStream(audio_task_runner()); 82 new MockVirtualAudioInputStream(audio_task_runner());
81 audio_task_runner()->PostTask( 83 audio_task_runner()->PostTask(
82 FROM_HERE, base::Bind( 84 FROM_HERE, base::Bind(
83 base::IgnoreResult(&MockVirtualAudioInputStream::Open), 85 base::IgnoreResult(&MockVirtualAudioInputStream::Open),
84 base::Unretained(input_stream))); 86 base::Unretained(input_stream)));
85 87
86 VirtualAudioOutputStream* const output_stream = new VirtualAudioOutputStream( 88 VirtualAudioOutputStream* const output_stream = new VirtualAudioOutputStream(
87 kParams, 89 kParams,
88 input_stream, 90 input_stream,
89 base::Bind(&base::DeletePointer<VirtualAudioOutputStream>)); 91 base::Bind(&DeleteVirtualAudioOutputStream));
90 92
91 EXPECT_CALL(*input_stream, AddOutputStream(output_stream, _)) 93 EXPECT_CALL(*input_stream, AddOutputStream(output_stream, _))
92 .Times(kCycles); 94 .Times(kCycles);
93 EXPECT_CALL(*input_stream, RemoveOutputStream(output_stream, _)) 95 EXPECT_CALL(*input_stream, RemoveOutputStream(output_stream, _))
94 .Times(kCycles); 96 .Times(kCycles);
95 97
96 audio_task_runner()->PostTask( 98 audio_task_runner()->PostTask(
97 FROM_HERE, base::Bind(base::IgnoreResult(&VirtualAudioOutputStream::Open), 99 FROM_HERE, base::Bind(base::IgnoreResult(&VirtualAudioOutputStream::Open),
98 base::Unretained(output_stream))); 100 base::Unretained(output_stream)));
99 SineWaveAudioSource source(CHANNEL_LAYOUT_STEREO, 200.0, 128); 101 SineWaveAudioSource source(CHANNEL_LAYOUT_STEREO, 200.0, 128);
(...skipping 11 matching lines...) Expand all
111 base::Unretained(output_stream))); 113 base::Unretained(output_stream)));
112 114
113 audio_task_runner()->PostTask( 115 audio_task_runner()->PostTask(
114 FROM_HERE, base::Bind(&MockVirtualAudioInputStream::Close, 116 FROM_HERE, base::Bind(&MockVirtualAudioInputStream::Close,
115 base::Unretained(input_stream))); 117 base::Unretained(input_stream)));
116 118
117 SyncWithAudioThread(); 119 SyncWithAudioThread();
118 } 120 }
119 121
120 } // namespace media 122 } // namespace media
OLDNEW
« no previous file with comments | « media/audio/virtual_audio_input_stream_unittest.cc ('k') | media/cast/sender/video_encoder_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698