Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: dbus/object_proxy.h

Issue 1074963003: Clean up potentially leaky use of base::DeletePointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed another probleb Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « dbus/object_manager.cc ('k') | dbus/object_proxy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DBUS_OBJECT_PROXY_H_ 5 #ifndef DBUS_OBJECT_PROXY_H_
6 #define DBUS_OBJECT_PROXY_H_ 6 #define DBUS_OBJECT_PROXY_H_
7 7
8 #include <dbus/dbus.h> 8 #include <dbus/dbus.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 void WaitForServiceToBeAvailableInternal(); 242 void WaitForServiceToBeAvailableInternal();
243 243
244 // Handles the incoming request messages and dispatches to the signal 244 // Handles the incoming request messages and dispatches to the signal
245 // callbacks. 245 // callbacks.
246 DBusHandlerResult HandleMessage(DBusConnection* connection, 246 DBusHandlerResult HandleMessage(DBusConnection* connection,
247 DBusMessage* raw_message); 247 DBusMessage* raw_message);
248 248
249 // Runs the method. Helper function for HandleMessage(). 249 // Runs the method. Helper function for HandleMessage().
250 void RunMethod(base::TimeTicks start_time, 250 void RunMethod(base::TimeTicks start_time,
251 std::vector<SignalCallback> signal_callbacks, 251 std::vector<SignalCallback> signal_callbacks,
252 Signal* signal); 252 scoped_ptr<Signal> signal);
253 253
254 // Redirects the function call to HandleMessage(). 254 // Redirects the function call to HandleMessage().
255 static DBusHandlerResult HandleMessageThunk(DBusConnection* connection, 255 static DBusHandlerResult HandleMessageThunk(DBusConnection* connection,
256 DBusMessage* raw_message, 256 DBusMessage* raw_message,
257 void* user_data); 257 void* user_data);
258 258
259 // Helper method for logging response errors appropriately. 259 // Helper method for logging response errors appropriately.
260 void LogMethodCallFailure(const base::StringPiece& interface_name, 260 void LogMethodCallFailure(const base::StringPiece& interface_name,
261 const base::StringPiece& method_name, 261 const base::StringPiece& method_name,
262 const base::StringPiece& error_name, 262 const base::StringPiece& error_name,
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 std::string service_name_owner_; 317 std::string service_name_owner_;
318 318
319 std::set<DBusPendingCall*> pending_calls_; 319 std::set<DBusPendingCall*> pending_calls_;
320 320
321 DISALLOW_COPY_AND_ASSIGN(ObjectProxy); 321 DISALLOW_COPY_AND_ASSIGN(ObjectProxy);
322 }; 322 };
323 323
324 } // namespace dbus 324 } // namespace dbus
325 325
326 #endif // DBUS_OBJECT_PROXY_H_ 326 #endif // DBUS_OBJECT_PROXY_H_
OLDNEW
« no previous file with comments | « dbus/object_manager.cc ('k') | dbus/object_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698