Issue 1074953004: Remove empty-cells

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1074953004: Remove empty-cells (Closed)

Created:
5 years, 8 months ago by eseidel

Modified:
5 years, 8 months ago

Reviewers:
Hixie

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove empty-cells The world may never know what to do with empty cells? Besides. This was mislabled as layout, it was clearly a paint property. :p R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/07b1b9e4a796985a787d0c6c1cc199fff40a010d

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -50 lines)			Patch
M	sky/engine/core/css/CSSComputedStyleDeclaration.cpp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/css/CSSPrimitiveValueMappings.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	sky/engine/core/css/CSSProperties.in	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/css/parser/BisonCSSParser-in.cpp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/rendering/style/RenderStyle.h	View	6 chunks	+1 line, -7 lines	0 comments	Download
M	sky/engine/core/rendering/style/RenderStyleConstants.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

eseidel

5 years, 8 months ago (2015-04-09 21:54:22 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
07b1b9e4a796985a787d0c6c1cc199fff40a010d (presubmit successful).