src/ppc/simulator-ppc.cc - Issue 1074943002: Split TemplateHashMapImpl::Lookup into two methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ppc/simulator-ppc.cc

Issue 1074943002: Split TemplateHashMapImpl::Lookup into two methods (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix arm (and ppc) builds Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ppc/simulator-ppc.cc

diff --git a/src/ppc/simulator-ppc.cc b/src/ppc/simulator-ppc.cc

index 9b29004f3d3e041bacfba39061a081108a6558cf..7139ead2134aff860c657c7099d347b62a884f8d 100644

--- a/src/ppc/simulator-ppc.cc

+++ b/src/ppc/simulator-ppc.cc

@@ -729,7 +729,7 @@ void Simulator::FlushICache(v8::internal::HashMap* i_cache, void* start_addr,

CachePage* Simulator::GetCachePage(v8::internal::HashMap* i_cache, void* page) {

v8::internal::HashMap::Entry* entry =

- i_cache->Lookup(page, ICacheHash(page), true);

+ i_cache->LookupOrInsert(page, ICacheHash(page));

if (entry->value == NULL) {

CachePage* new_page = new CachePage();

entry->value = new_page;