Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1074923003: rename dart_runtime.js helpers (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly
Modified:
5 years, 8 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

rename dart_runtime.js helpers this should make the diff simpler in the other CL R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/f625023367849b43f711f889c4a1910ab1df54f4

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -285 lines) Patch
M lib/runtime/dart/_foreign_helper.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_interceptors.js View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/runtime/dart/_internal.js View 20 chunks +38 lines, -38 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 11 chunks +18 lines, -18 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 27 chunks +67 lines, -67 lines 0 comments Download
M lib/runtime/dart/_native_typed_data.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/async.js View 25 chunks +53 lines, -53 lines 0 comments Download
M lib/runtime/dart/collection.js View 26 chunks +36 lines, -36 lines 0 comments Download
M lib/runtime/dart/convert.js View 12 chunks +13 lines, -13 lines 0 comments Download
M lib/runtime/dart/core.js View 18 chunks +28 lines, -28 lines 0 comments Download
M lib/runtime/dart_runtime.js View 2 chunks +4 lines, -9 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M test/codegen/expect/BenchmarkBase.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/cascade.js View 3 chunks +6 lines, -6 lines 0 comments Download
M test/codegen/expect/methods.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/opassign.js View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
5 years, 8 months ago (2015-04-14 19:23:39 UTC) #3
Jacob
lgtm
5 years, 8 months ago (2015-04-14 20:07:24 UTC) #4
Jennifer Messerly
5 years, 8 months ago (2015-04-14 20:48:42 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) manually as
f625023367849b43f711f889c4a1910ab1df54f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698