Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1074843002: Fix RenderFrameProxyHost leak. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
*Charlie Reis, lfg
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lucasfix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix RenderFrameProxyHost leak. This was a regression that started with https://codereview.chromium.org/1055203002/ The test here was a gift from lfg@ BUG=475265 Committed: https://crrev.com/59dcb167ab88fd1c267e29304b1d4e43c58c2894 Cr-Commit-Position: refs/heads/master@{#324497}

Patch Set 1 #

Patch Set 2 : Re-upload with correct base. #

Patch Set 3 : Self-review fixes. #

Total comments: 1

Patch Set 4 : Add comment suggested by Charlie #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -4 lines) Patch
M content/browser/frame_host/render_frame_host_manager.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/site_per_process_browsertest.h View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 3 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ncarter (slow)
Charlie, please take a look. This fixes the regression. There were other tests that exercised ...
5 years, 8 months ago (2015-04-09 16:46:18 UTC) #3
Charlie Reis
[+site-isolation-reviews] Thanks! LGTM with nit. https://codereview.chromium.org/1074843002/diff/40001/content/browser/site_per_process_browsertest.h File content/browser/site_per_process_browsertest.h (right): https://codereview.chromium.org/1074843002/diff/40001/content/browser/site_per_process_browsertest.h#newcode19 content/browser/site_per_process_browsertest.h:19: // Returns an alphabetically-sorted ...
5 years, 8 months ago (2015-04-09 16:58:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074843002/60001
5 years, 8 months ago (2015-04-09 17:32:01 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-09 20:29:13 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 20:30:11 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/59dcb167ab88fd1c267e29304b1d4e43c58c2894
Cr-Commit-Position: refs/heads/master@{#324497}

Powered by Google App Engine
This is Rietveld 408576698