Remove isSupportedAttribute in svg

Source/core/svg/SVGImageElement.cpp

Index: Source/core/svg/SVGImageElement.cpp
diff --git a/Source/core/svg/SVGImageElement.cpp b/Source/core/svg/SVGImageElement.cpp
index e1197b20bed74499a94f4a134c4440879f22b192..76b3e16501feef6069a0ded545144025842ef65b 100644
--- a/Source/core/svg/SVGImageElement.cpp
+++ b/Source/core/svg/SVGImageElement.cpp
@@ -74,20 +74,6 @@ bool SVGImageElement::currentFrameHasSingleSecurityOrigin() const
     return true;
 }
 
-bool SVGImageElement::isSupportedAttribute(const QualifiedName& attrName)
-{
-    DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
-    if (supportedAttributes.isEmpty()) {
-        SVGURIReference::addSupportedAttributes(supportedAttributes);
-        supportedAttributes.add(SVGNames::xAttr);
-        supportedAttributes.add(SVGNames::yAttr);
-        supportedAttributes.add(SVGNames::widthAttr);
-        supportedAttributes.add(SVGNames::heightAttr);
-        supportedAttributes.add(SVGNames::preserveAspectRatioAttr);
-    }
-    return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
-}
-
 bool SVGImageElement::isPresentationAttribute(const QualifiedName& attrName) const
 {
     if (attrName == SVGNames::xAttr || attrName == SVGNames::yAttr
@@ -122,13 +108,6 @@ void SVGImageElement::collectStyleForPresentationAttribute(const QualifiedName&
 
 void SVGImageElement::svgAttributeChanged(const QualifiedName& attrName)
 {
-    if (!isSupportedAttribute(attrName)) {
-        SVGGraphicsElement::svgAttributeChanged(attrName);
-        return;
-    }
-
-    SVGElement::InvalidationGuard invalidationGuard(this);
-
     bool isLengthAttribute = attrName == SVGNames::xAttr
                           || attrName == SVGNames::yAttr
                           || attrName == SVGNames::widthAttr
@@ -141,28 +120,31 @@ void SVGImageElement::svgAttributeChanged(const QualifiedName& attrName)
         updateRelativeLengthsInformation();

[pdr., 2015/04/10 18:39:21]

Does this path need to be covered by the invalidation guard (here, and
elsewhere?) The code is inconsistent whether it should be covered with the
invalidation guard.

[Erik Dahlström (inactive), 2015/04/13 08:11:17]

Hmm, yes I think it should be covered by that. I had another look at the other
places like this and they looked fine to me, tried to make things a bit more
consistent in the latest patchset.

     }
 
-    if (SVGURIReference::isKnownAttribute(attrName)) {
-        if (inDocument())
-            imageLoader().updateFromElement(ImageLoader::UpdateIgnorePreviousError);
-        else
-            m_needsLoaderURIUpdate = true;
-        return;
-    }
+    if (isLengthAttribute || attrName == SVGNames::preserveAspectRatioAttr) {
+        SVGElement::InvalidationGuard invalidationGuard(this);
 
-    LayoutObject* renderer = this->layoutObject();
-    if (!renderer)
-        return;
+        LayoutObject* object = this->layoutObject();
+        if (!object)
+            return;
 
-    if (isLengthAttribute || attrName == SVGNames::preserveAspectRatioAttr) {
         // FIXME: if isLengthAttribute then we should avoid this
         // call if the viewport didn't change, however since we don't
         // have the computed style yet we can't use updateImageViewport.
         // See http://crbug.com/466200.
-        markForLayoutAndParentResourceInvalidation(renderer);
+        markForLayoutAndParentResourceInvalidation(object);
+        return;
+    }
+
+    if (SVGURIReference::isKnownAttribute(attrName)) {
+        SVGElement::InvalidationGuard invalidationGuard(this);
+        if (inDocument())
+            imageLoader().updateFromElement(ImageLoader::UpdateIgnorePreviousError);
+        else
+            m_needsLoaderURIUpdate = true;
         return;
     }
 
-    ASSERT_NOT_REACHED();
+    SVGGraphicsElement::svgAttributeChanged(attrName);
 }
 
 bool SVGImageElement::selfHasRelativeLengths() const