Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: Source/core/svg/SVGSVGElement.cpp

Issue 1074813002: Remove isSupportedAttribute in svg (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: invalidation guard tweaks Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGRectElement.cpp ('k') | Source/core/svg/SVGTextContentElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2007 Apple Inc. All rights reserved.
5 * Copyright (C) 2014 Google, Inc. 5 * Copyright (C) 2014 Google, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 StyleChangeReasonForTracing::fromAttribute(attrName)); 312 StyleChangeReasonForTracing::fromAttribute(attrName));
313 } 313 }
314 } 314 }
315 315
316 if (SVGFitToViewBox::isKnownAttribute(attrName)) { 316 if (SVGFitToViewBox::isKnownAttribute(attrName)) {
317 updateRelativeLengthsOrViewBox = true; 317 updateRelativeLengthsOrViewBox = true;
318 if (LayoutObject* object = layoutObject()) 318 if (LayoutObject* object = layoutObject())
319 object->setNeedsTransformUpdate(); 319 object->setNeedsTransformUpdate();
320 } 320 }
321 321
322 SVGElement::InvalidationGuard invalidationGuard(this);
323
324 if (updateRelativeLengthsOrViewBox 322 if (updateRelativeLengthsOrViewBox
325 || SVGZoomAndPan::isKnownAttribute(attrName)) { 323 || SVGZoomAndPan::isKnownAttribute(attrName)) {
324 SVGElement::InvalidationGuard invalidationGuard(this);
Erik Dahlström (inactive) 2015/04/13 08:11:17 Note that all the above branches sets updateRelati
326 if (layoutObject()) 325 if (layoutObject())
327 markForLayoutAndParentResourceInvalidation(layoutObject()); 326 markForLayoutAndParentResourceInvalidation(layoutObject());
328 return; 327 return;
329 } 328 }
330 329
331 SVGGraphicsElement::svgAttributeChanged(attrName); 330 SVGGraphicsElement::svgAttributeChanged(attrName);
332 } 331 }
333 332
334 // FloatRect::intersects does not consider horizontal or vertical lines (because of isEmpty()). 333 // FloatRect::intersects does not consider horizontal or vertical lines (because of isEmpty()).
335 static bool intersectsAllowingEmpty(const FloatRect& r1, const FloatRect& r2) 334 static bool intersectsAllowingEmpty(const FloatRect& r1, const FloatRect& r2)
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
782 visitor->trace(m_width); 781 visitor->trace(m_width);
783 visitor->trace(m_height); 782 visitor->trace(m_height);
784 visitor->trace(m_translation); 783 visitor->trace(m_translation);
785 visitor->trace(m_timeContainer); 784 visitor->trace(m_timeContainer);
786 visitor->trace(m_viewSpec); 785 visitor->trace(m_viewSpec);
787 SVGGraphicsElement::trace(visitor); 786 SVGGraphicsElement::trace(visitor);
788 SVGFitToViewBox::trace(visitor); 787 SVGFitToViewBox::trace(visitor);
789 } 788 }
790 789
791 } // namespace blink 790 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/svg/SVGRectElement.cpp ('k') | Source/core/svg/SVGTextContentElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698