Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: Source/core/svg/SVGRadialGradientElement.cpp

Issue 1074813002: Remove isSupportedAttribute in svg (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: invalidation guard tweaks Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2008 Dirk Schulze <krit@webkit.org> 5 * Copyright (C) 2008 Dirk Schulze <krit@webkit.org>
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 visitor->trace(m_cy); 60 visitor->trace(m_cy);
61 visitor->trace(m_r); 61 visitor->trace(m_r);
62 visitor->trace(m_fx); 62 visitor->trace(m_fx);
63 visitor->trace(m_fy); 63 visitor->trace(m_fy);
64 visitor->trace(m_fr); 64 visitor->trace(m_fr);
65 SVGGradientElement::trace(visitor); 65 SVGGradientElement::trace(visitor);
66 } 66 }
67 67
68 DEFINE_NODE_FACTORY(SVGRadialGradientElement) 68 DEFINE_NODE_FACTORY(SVGRadialGradientElement)
69 69
70 bool SVGRadialGradientElement::isSupportedAttribute(const QualifiedName& attrNam e)
71 {
72 DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
73 if (supportedAttributes.isEmpty()) {
74 supportedAttributes.add(SVGNames::cxAttr);
75 supportedAttributes.add(SVGNames::cyAttr);
76 supportedAttributes.add(SVGNames::fxAttr);
77 supportedAttributes.add(SVGNames::fyAttr);
78 supportedAttributes.add(SVGNames::rAttr);
79 supportedAttributes.add(SVGNames::frAttr);
80 }
81 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
82 }
83
84 void SVGRadialGradientElement::svgAttributeChanged(const QualifiedName& attrName ) 70 void SVGRadialGradientElement::svgAttributeChanged(const QualifiedName& attrName )
85 { 71 {
86 if (!isSupportedAttribute(attrName)) { 72 if (attrName == SVGNames::cxAttr || attrName == SVGNames::cyAttr
87 SVGGradientElement::svgAttributeChanged(attrName); 73 || attrName == SVGNames::fxAttr || attrName == SVGNames::fyAttr
74 || attrName == SVGNames::rAttr || attrName == SVGNames::frAttr) {
75 SVGElement::InvalidationGuard invalidationGuard(this);
76
77 updateRelativeLengthsInformation();
78
79 LayoutSVGResourceContainer* renderer = toLayoutSVGResourceContainer(this ->layoutObject());
80 if (renderer)
81 renderer->invalidateCacheAndMarkForLayout();
82
88 return; 83 return;
89 } 84 }
90 85
91 SVGElement::InvalidationGuard invalidationGuard(this); 86 SVGGradientElement::svgAttributeChanged(attrName);
92
93 updateRelativeLengthsInformation();
94
95 LayoutSVGResourceContainer* renderer = toLayoutSVGResourceContainer(this->la youtObject());
96 if (renderer)
97 renderer->invalidateCacheAndMarkForLayout();
98 } 87 }
99 88
100 LayoutObject* SVGRadialGradientElement::createLayoutObject(const ComputedStyle&) 89 LayoutObject* SVGRadialGradientElement::createLayoutObject(const ComputedStyle&)
101 { 90 {
102 return new LayoutSVGResourceRadialGradient(this); 91 return new LayoutSVGResourceRadialGradient(this);
103 } 92 }
104 93
105 static void setGradientAttributes(SVGGradientElement* element, RadialGradientAtt ributes& attributes, bool isRadial = true) 94 static void setGradientAttributes(SVGGradientElement* element, RadialGradientAtt ributes& attributes, bool isRadial = true)
106 { 95 {
107 if (!attributes.hasSpreadMethod() && element->spreadMethod()->isSpecified()) 96 if (!attributes.hasSpreadMethod() && element->spreadMethod()->isSpecified())
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 { 179 {
191 return m_cx->currentValue()->isRelative() 180 return m_cx->currentValue()->isRelative()
192 || m_cy->currentValue()->isRelative() 181 || m_cy->currentValue()->isRelative()
193 || m_r->currentValue()->isRelative() 182 || m_r->currentValue()->isRelative()
194 || m_fx->currentValue()->isRelative() 183 || m_fx->currentValue()->isRelative()
195 || m_fy->currentValue()->isRelative() 184 || m_fy->currentValue()->isRelative()
196 || m_fr->currentValue()->isRelative(); 185 || m_fr->currentValue()->isRelative();
197 } 186 }
198 187
199 } // namespace blink 188 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698