Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: Source/core/svg/SVGFEOffsetElement.cpp

Issue 1074813002: Remove isSupportedAttribute in svg (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: invalidation guard tweaks Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 DEFINE_TRACE(SVGFEOffsetElement) 42 DEFINE_TRACE(SVGFEOffsetElement)
43 { 43 {
44 visitor->trace(m_dx); 44 visitor->trace(m_dx);
45 visitor->trace(m_dy); 45 visitor->trace(m_dy);
46 visitor->trace(m_in1); 46 visitor->trace(m_in1);
47 SVGFilterPrimitiveStandardAttributes::trace(visitor); 47 SVGFilterPrimitiveStandardAttributes::trace(visitor);
48 } 48 }
49 49
50 DEFINE_NODE_FACTORY(SVGFEOffsetElement) 50 DEFINE_NODE_FACTORY(SVGFEOffsetElement)
51 51
52 bool SVGFEOffsetElement::isSupportedAttribute(const QualifiedName& attrName)
53 {
54 DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
55 if (supportedAttributes.isEmpty()) {
56 supportedAttributes.add(SVGNames::inAttr);
57 supportedAttributes.add(SVGNames::dxAttr);
58 supportedAttributes.add(SVGNames::dyAttr);
59 }
60 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
61 }
62
63 void SVGFEOffsetElement::svgAttributeChanged(const QualifiedName& attrName) 52 void SVGFEOffsetElement::svgAttributeChanged(const QualifiedName& attrName)
64 { 53 {
65 if (!isSupportedAttribute(attrName)) { 54 if (attrName == SVGNames::inAttr || attrName == SVGNames::dxAttr
66 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName); 55 || attrName == SVGNames::dyAttr) {
56 SVGElement::InvalidationGuard invalidationGuard(this);
57 invalidate();
67 return; 58 return;
68 } 59 }
69 60
70 SVGElement::InvalidationGuard invalidationGuard(this); 61 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName);
71 invalidate();
72 } 62 }
73 63
74 PassRefPtrWillBeRawPtr<FilterEffect> SVGFEOffsetElement::build(SVGFilterBuilder* filterBuilder, Filter* filter) 64 PassRefPtrWillBeRawPtr<FilterEffect> SVGFEOffsetElement::build(SVGFilterBuilder* filterBuilder, Filter* filter)
75 { 65 {
76 FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(m_in1->curr entValue()->value())); 66 FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(m_in1->curr entValue()->value()));
77 67
78 if (!input1) 68 if (!input1)
79 return nullptr; 69 return nullptr;
80 70
81 RefPtrWillBeRawPtr<FilterEffect> effect = FEOffset::create(filter, m_dx->cur rentValue()->value(), m_dy->currentValue()->value()); 71 RefPtrWillBeRawPtr<FilterEffect> effect = FEOffset::create(filter, m_dx->cur rentValue()->value(), m_dy->currentValue()->value());
82 effect->inputEffects().append(input1); 72 effect->inputEffects().append(input1);
83 return effect.release(); 73 return effect.release();
84 } 74 }
85 75
86 } // namespace blink 76 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698