Remove isSupportedAttribute in svg

Source/core/svg/SVGFELightElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
  * Copyright (C) 2005 Oliver Hunt <oliver@nerget.com>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 67 matching lines @@
 FloatPoint3D SVGFELightElement::position() const
 {
     return FloatPoint3D(x()->currentValue()->value(), y()->currentValue()->value(), z()->currentValue()->value());
 }
 
 FloatPoint3D SVGFELightElement::pointsAt() const
 {
     return FloatPoint3D(pointsAtX()->currentValue()->value(), pointsAtY()->currentValue()->value(), pointsAtZ()->currentValue()->value());
 }
 
-bool SVGFELightElement::isSupportedAttribute(const QualifiedName& attrName)
-{
-    DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
-    if (supportedAttributes.isEmpty()) {
-        supportedAttributes.add(SVGNames::azimuthAttr);
-        supportedAttributes.add(SVGNames::elevationAttr);
-        supportedAttributes.add(SVGNames::xAttr);
-        supportedAttributes.add(SVGNames::yAttr);
-        supportedAttributes.add(SVGNames::zAttr);
-        supportedAttributes.add(SVGNames::pointsAtXAttr);
-        supportedAttributes.add(SVGNames::pointsAtYAttr);
-        supportedAttributes.add(SVGNames::pointsAtZAttr);
-        supportedAttributes.add(SVGNames::specularExponentAttr);
-        supportedAttributes.add(SVGNames::limitingConeAngleAttr);
-    }
-    return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
-}
-
 void SVGFELightElement::svgAttributeChanged(const QualifiedName& attrName)
 {
-    if (!isSupportedAttribute(attrName)) {
-        SVGElement::svgAttributeChanged(attrName);
-        return;
-    }
-
-    SVGElement::InvalidationGuard invalidationGuard(this);
-
     if (attrName == SVGNames::azimuthAttr
         || attrName == SVGNames::elevationAttr
         || attrName == SVGNames::xAttr
         || attrName == SVGNames::yAttr
         || attrName == SVGNames::zAttr
         || attrName == SVGNames::pointsAtXAttr
         || attrName == SVGNames::pointsAtYAttr
         || attrName == SVGNames::pointsAtZAttr
         || attrName == SVGNames::specularExponentAttr
         || attrName == SVGNames::limitingConeAngleAttr) {
+        SVGElement::InvalidationGuard invalidationGuard(this);

[fs, 2015/04/10 14:25:24]

Move this down to just before isSVGFEDiffuseLightingElement (where things start
to go down for real.)

[Erik Dahlström (inactive), 2015/04/10 15:33:44]

Done.

         ContainerNode* parent = parentNode();
         if (!parent)
             return;
 
         LayoutObject* renderer = parent->layoutObject();
         if (!renderer || !renderer->isSVGResourceFilterPrimitive())
             return;
 
         if (isSVGFEDiffuseLightingElement(*parent)) {
             toSVGFEDiffuseLightingElement(*parent).lightElementAttributeChanged(this, attrName);
             return;
         }
         if (isSVGFESpecularLightingElement(*parent)) {
             toSVGFESpecularLightingElement(*parent).lightElementAttributeChanged(this, attrName);
             return;
         }
     }

[fs, 2015/04/10 14:25:24]

Should probably move the ASSERT_NOT_REACHED() here now.

[Erik Dahlström (inactive), 2015/04/10 15:33:44]

Done.

 
-    ASSERT_NOT_REACHED();
+    SVGElement::svgAttributeChanged(attrName);
 }
 
 void SVGFELightElement::childrenChanged(const ChildrenChange& change)
 {
     SVGElement::childrenChanged(change);
 
     if (!change.byParser) {
         if (ContainerNode* parent = parentNode()) {
             LayoutObject* renderer = parent->layoutObject();
             if (renderer && renderer->isSVGResourceFilterPrimitive())
                 markForLayoutAndParentResourceInvalidation(renderer);
         }
     }
 }
 
 }