Remove isSupportedAttribute in svg

Source/core/svg/SVGAnimationElement.cpp

 /*
  * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 140 matching lines @@
         parsed = parseKeySplinesInternal<LChar>(string, result);
     else
         parsed = parseKeySplinesInternal<UChar>(string, result);
     if (!parsed) {
         result.clear();
         return false;
     }
     return true;
 }
 
-bool SVGAnimationElement::isSupportedAttribute(const QualifiedName& attrName)
-{
-    DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
-    if (supportedAttributes.isEmpty()) {
-        supportedAttributes.add(SVGNames::valuesAttr);
-        supportedAttributes.add(SVGNames::keyTimesAttr);
-        supportedAttributes.add(SVGNames::keyPointsAttr);
-        supportedAttributes.add(SVGNames::keySplinesAttr);
-        supportedAttributes.add(SVGNames::attributeTypeAttr);
-        supportedAttributes.add(SVGNames::calcModeAttr);
-        supportedAttributes.add(SVGNames::fromAttr);
-        supportedAttributes.add(SVGNames::toAttr);
-        supportedAttributes.add(SVGNames::byAttr);
-    }
-    return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
-}
-
 void SVGAnimationElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
 {
-    if (!isSupportedAttribute(name)) {
-        SVGSMILElement::parseAttribute(name, value);
-        return;
-    }
-
     if (name == SVGNames::valuesAttr) {
         if (!parseValues(value, m_values)) {
             reportAttributeParsingError(ParsingAttributeFailedError, name, value);
             return;
         }
         updateAnimationMode();
         return;
     }
 
     if (name == SVGNames::keyTimesAttr) {
@@ skipping 26 matching lines @@
     if (name == SVGNames::calcModeAttr) {
         setCalcMode(value);
         return;
     }
 
     if (name == SVGNames::fromAttr || name == SVGNames::toAttr || name == SVGNames::byAttr) {
         updateAnimationMode();
         return;
     }
 
-    ASSERT_NOT_REACHED();
+    SVGSMILElement::parseAttribute(name, value);
+    SVGTests::parseAttribute(name, value);

[fs, 2015/04/10 14:25:23]

The SVGTests constructor adds all its attributes to the property map, so this
would've been handled by the property-map lookup in SVGElement::parseAttribute.

[Erik Dahlström (inactive), 2015/04/10 15:33:43]

Done.

 }
 
 void SVGAnimationElement::svgAttributeChanged(const QualifiedName& attrName)
 {
-    if (!isSupportedAttribute(attrName)) {
-        SVGSMILElement::svgAttributeChanged(attrName);
+    if (attrName == SVGNames::valuesAttr
+        || attrName == SVGNames::byAttr
+        || attrName == SVGNames::fromAttr
+        || attrName == SVGNames::toAttr
+        || attrName == SVGNames::calcModeAttr
+        || attrName == SVGNames::attributeTypeAttr
+        || attrName == SVGNames::keySplinesAttr
+        || attrName == SVGNames::keyPointsAttr
+        || attrName == SVGNames::keyTimesAttr) {
+        animationAttributeChanged();
         return;
     }
 
-    animationAttributeChanged();
+    SVGSMILElement::svgAttributeChanged(attrName);
 }
 
 void SVGAnimationElement::animationAttributeChanged()
 {
     // Assumptions may not hold after an attribute change.
     m_animationValid = false;
     m_lastValuesAnimationFrom = String();
     m_lastValuesAnimationTo = String();
     setInactive();
 }
@@ skipping 474 matching lines @@
         if (!hasInvalidCSSAttributeType)
             schedule();
     }
 
     // Clear values that may depend on the previous target.
     if (targetElement())
         clearAnimatedType();
 }
 
 }