Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issue 1074793003: [turbofan] Fix FrameInspector when deoptimizer is disabled. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix FrameInspector when deoptimizer is disabled. This is a workaround to make the debugger happy about TurboFan frames when the debugger causes frame inspection. Note that this can happen because the debugger can be activated while there still are optimized TurboFan activations on the stack. R=ishell@chromium.org BUG=chromium:465298 TEST=mjsunit/regress/regress-crbug-465298 LOG=N Committed: https://crrev.com/96ef78aa0b664f08d906299f16ffc5dc9dded40f Cr-Commit-Position: refs/heads/master@{#27717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -3 lines) Patch
M src/runtime/runtime-debug.cc View 2 chunks +13 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-465298.js View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 8 months ago (2015-04-09 16:04:54 UTC) #1
Igor Sheludko
lgtm
5 years, 8 months ago (2015-04-09 16:20:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074793003/1
5 years, 8 months ago (2015-04-09 16:26:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 19:40:50 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 19:41:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96ef78aa0b664f08d906299f16ffc5dc9dded40f
Cr-Commit-Position: refs/heads/master@{#27717}

Powered by Google App Engine
This is Rietveld 408576698