Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 107473002: Make Mojo work on Android again (Closed)

Created:
7 years ago by abarth-chromium
Modified:
7 years ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make Mojo work on Android again This CL fixes mojo_shell to work on Android again. This time we're using the static build, which means we don't need to keep track of all the many components. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239797

Patch Set 1 #

Patch Set 2 : Fix win #

Patch Set 3 : Attempt to fix win again #

Patch Set 4 : Fix system exports #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
A mojo/build/package_app.gypi View 1 2 5 1 chunk +31 lines, -0 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/LibraryLoader.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
abarth-chromium
7 years ago (2013-12-05 23:15:20 UTC) #1
abarth-chromium
I need to update http://dev.chromium.org/developers/how-tos/run-mojo-shell after this CL.
7 years ago (2013-12-05 23:17:23 UTC) #2
darin (slow to review)
OK, LGTM
7 years ago (2013-12-06 03:01:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/107473002/1
7 years ago (2013-12-06 04:18:02 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
7 years ago (2013-12-06 05:31:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/107473002/20001
7 years ago (2013-12-06 08:53:22 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=59502
7 years ago (2013-12-06 09:48:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/107473002/40001
7 years ago (2013-12-07 16:20:25 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
7 years ago (2013-12-07 17:34:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/107473002/60001
7 years ago (2013-12-07 19:23:21 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) cacheinvalidation_unittests, cc_unittests, check_deps, chromedriver2_unittests, components_unittests, content_browsertests, ...
7 years ago (2013-12-07 19:38:38 UTC) #11
abarth-chromium
I split off the dylib structure change in https://codereview.chromium.org/106173003
7 years ago (2013-12-09 08:24:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/107473002/100001
7 years ago (2013-12-10 14:45:05 UTC) #13
abarth-chromium
7 years ago (2013-12-10 17:18:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #6 manually as r239797 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698