Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1074683003: X87: Code cleanup in GenerateRecordCallTarget. (Closed)

Created:
5 years, 8 months ago by chunyang.dai
Modified:
5 years, 8 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Code cleanup in GenerateRecordCallTarget. port 6a222b8ff033eb523149794d37c0d0f29bc8fc40 (r27630) original commit message: Code cleanup in GenerateRecordCallTarget BUG= Committed: https://crrev.com/8f3b3ba6ba6fc384bcc02db72ed4407fadd2331d Cr-Commit-Position: refs/heads/master@{#27694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/x87/code-stubs-x87.cc View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 8 months ago (2015-04-09 09:04:35 UTC) #2
Weiliang
lgtm
5 years, 8 months ago (2015-04-09 09:05:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074683003/1
5 years, 8 months ago (2015-04-09 09:05:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 09:31:57 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 09:32:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f3b3ba6ba6fc384bcc02db72ed4407fadd2331d
Cr-Commit-Position: refs/heads/master@{#27694}

Powered by Google App Engine
This is Rietveld 408576698