Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1074583002: Testing and bugfixing for the new MB gyp/gn wrapper. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Testing and bugfixing for the new MB gyp/gn wrapper. This fixes a number of small issues I found while actually testing things to get it ready to run on the bots. In particular, 'mb analyze' didn't work right for GN. Tests were added. TBR=brettw@chromium.org BUG=466436 Committed: https://crrev.com/ee5b51f66b77a6d92ce46e0b119f3654deacac12 Cr-Commit-Position: refs/heads/master@{#324312}

Patch Set 1 : clarify comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -45 lines) Patch
M tools/mb/docs/user_guide.md View 2 chunks +8 lines, -6 lines 0 comments Download
M tools/mb/mb.py View 7 chunks +17 lines, -18 lines 1 comment Download
M tools/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download
M tools/mb/mb_unittest.py View 5 chunks +48 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Dirk Pranke
https://codereview.chromium.org/1074583002/diff/40001/tools/mb/mb.py File tools/mb/mb.py (left): https://codereview.chromium.org/1074583002/diff/40001/tools/mb/mb.py#oldcode288 tools/mb/mb.py:288: raise MBErr('Cycle in mixins for "%s": %s' % (m, ...
5 years, 8 months ago (2015-04-08 21:37:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074583002/40001
5 years, 8 months ago (2015-04-08 21:37:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 8 months ago (2015-04-09 00:03:29 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 00:04:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee5b51f66b77a6d92ce46e0b119f3654deacac12
Cr-Commit-Position: refs/heads/master@{#324312}

Powered by Google App Engine
This is Rietveld 408576698