Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1074553002: [Android] Properly filter GestureFlingCancel events (Closed)

Created:
5 years, 8 months ago by jdduke (slow)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, penghuang+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Properly filter GestureFlingCancel events The browser will drop GestureFlingCancel events when it believes the renderer has no active fling animations. However, this filtering would report the event as "consumed", inadverently triggering tap suppression logic for the subsequent tap. Instead, report "no consumer exists" for the filtered GestureFlingCancel events, avoiding spurious tap suppression. BUG=474882 Committed: https://crrev.com/92801d31b071372560733001086a6e31f58e1ae0 Cr-Commit-Position: refs/heads/master@{#324288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +16 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jdduke (slow)
aelias@: PTAL, thanks.
5 years, 8 months ago (2015-04-08 19:34:19 UTC) #2
aelias_OOO_until_Jul13
lgtm
5 years, 8 months ago (2015-04-08 19:54:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074553002/1
5 years, 8 months ago (2015-04-08 20:11:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 21:40:11 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 21:41:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92801d31b071372560733001086a6e31f58e1ae0
Cr-Commit-Position: refs/heads/master@{#324288}

Powered by Google App Engine
This is Rietveld 408576698