Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2162)

Unified Diff: net/spdy/spdy_session.cc

Issue 1074523002: Disable logging of failed SPDY PINGs in a timemax bucket, and update histogram bucketing strategy f… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index db791e466b125387d1b4eb028e13d0de20803628..a0f5d58cc22a2f9b00823db13e3d99c35ba12e60 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -2964,8 +2964,6 @@ void SpdySession::CheckPingStatus(base::TimeTicks last_check_time) {
base::TimeDelta delay = hung_interval_ - (now - last_activity_time_);
if (delay.InMilliseconds() < 0 || last_activity_time_ < last_check_time) {
- // Track all failed PING messages in a separate bucket.
- RecordPingRTTHistogram(base::TimeDelta::Max());
DoDrainSession(ERR_SPDY_PING_FAILED, "Failed ping.");
return;
}
@@ -2979,7 +2977,9 @@ void SpdySession::CheckPingStatus(base::TimeTicks last_check_time) {
}
void SpdySession::RecordPingRTTHistogram(base::TimeDelta duration) {
- UMA_HISTOGRAM_TIMES("Net.SpdyPing.RTT", duration);
+ UMA_HISTOGRAM_CUSTOM_TIMES("Net.SpdyPing.RTT", duration,
+ base::TimeDelta::FromMilliseconds(1),
+ base::TimeDelta::FromMinutes(10), 100);
}
void SpdySession::RecordProtocolErrorHistogram(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698