Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1074513002: Use opaque black not transparent black as imagefilter GM background. (Closed)

Created:
5 years, 8 months ago by Stephen White
Modified:
5 years, 8 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use opaque black not transparent black as imagefilter GM background. For some reason, GM's are now being composited against white in some modes, where the alpha used to be ignored (or composited against black, I'm not sure which). At any rate, it doesn't make much sense to have alpha in the result anyway, so let's clear to opaque black instead of transparent black and avoid the problem. This is a trial balloon for bitmapsource and pictureimagefilter. If all goes well, I'll make this change more widely. R=scroggo BUG=skia:3319 Committed: https://skia.googlesource.com/skia/+/aad8b27ec6ff93b64f458be78a3eff7e91b10e15

Patch Set 1 #

Patch Set 2 : Revert some unnecessary changes #

Patch Set 3 : Make pictureimagefilter clear the canvas as well as the picture to opaque black #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gm/bitmapsource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/pictureimagefilter.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Stephen White
scroggo@: PTAL. Thanks!
5 years, 8 months ago (2015-04-08 17:56:57 UTC) #1
scroggo
LGTM. Thanks! > For some reason, GM's are now being composited against > white in ...
5 years, 8 months ago (2015-04-08 18:46:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074513002/40001
5 years, 8 months ago (2015-04-08 18:48:24 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 19:36:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/aad8b27ec6ff93b64f458be78a3eff7e91b10e15

Powered by Google App Engine
This is Rietveld 408576698