Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1074503002: ozone: evdev: Fix repeating the same key after r324081 (Closed)

Created:
5 years, 8 months ago by spang
Modified:
5 years, 8 months ago
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Fix repeating the same key after r324081 We broke repeating the same key twice in a row in r324081. Cancelling repeat must update the repeated key, so that we can tell that we need to start a new repeat for that key in UpdateKeyRepeat if it's pressed again. TEST=Repeat the same key twice in a row on link BUG=473446 Committed: https://crrev.com/57d2aaf3f94ef2228cabfbda58e64389ee65b6db Cr-Commit-Position: refs/heads/master@{#324263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/events/ozone/evdev/keyboard_evdev.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
spang
5 years, 8 months ago (2015-04-08 17:33:56 UTC) #2
spang
5 years, 8 months ago (2015-04-08 17:35:22 UTC) #4
alexst (slow to review)
lgtm
5 years, 8 months ago (2015-04-08 17:45:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074503002/1
5 years, 8 months ago (2015-04-08 17:47:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 19:14:54 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 19:16:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57d2aaf3f94ef2228cabfbda58e64389ee65b6db
Cr-Commit-Position: refs/heads/master@{#324263}

Powered by Google App Engine
This is Rietveld 408576698