Issue 1074463003: Return after throwing an exception when ConvolerNode.buffer rate is wrong.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1074463003: Return after throwing an exception when ConvolerNode.buffer rate is wrong. (Closed)

Created:
5 years, 8 months ago by Raymond Toy

Modified:
5 years, 8 months ago

Reviewers:
Ken Russell (switch to Gerrit), hongchan

CC:
blink-reviews, Raymond Toy

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Return after throwing an exception when ConvolerNode.buffer rate is wrong. If the exception for the incorrect sample rate was caught, we still continued and set the buffer to the wrong thing. We need to return after throwing the exception. BUG=352776 TEST=dom-exceptions.html updated with test Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193389

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -1 line)			Patch
M	LayoutTests/webaudio/dom-exceptions.html	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	LayoutTests/webaudio/dom-exceptions-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/modules/webaudio/ConvolverNode.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074463003/1

5 years, 8 months ago (2015-04-08 21:05:02 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-08 23:04:58 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193389

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages