Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 107443009: Address memory leak in SkScaledImageCache (Closed)

Created:
7 years ago by robertphillips
Modified:
7 years ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This is intended to address the valgrind complaint: 1,864 (128 direct, 1,736 indirect) bytes in 1 blocks are definitely lost in loss record 823 of 916 ==4572== at 0x4C2B1C7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==4572== by 0x55072A: SkScaledImageCache::addAndLock(SkBitmap const&, float, float, SkBitmap const&) (SkScaledImageCache.cpp:468) ==4572== by 0x440791: skiatest::ImageCache_doubleAddClass::onRun(skiatest::Reporter*) (ImageCacheTest.cpp:121) ==4572== by 0x48C07A: skiatest::Test::run() (Test.cpp:107) ==4572== by 0x4863D0: SkTestRunnable::run() (skia_test.cpp:155) ==4572== by 0x629D95: SkThreadPool::Loop(void*) (SkThreadPool.cpp:97) ==4572== by 0x634462: thread_start(void*) (SkThreadUtils_pthread.cpp:66) ==4572== by 0x4E39E99: start_thread (pthread_create.c:308) ==4572== by 0x6A02CBC: clone (clone.S:112)

Patch Set 1 #

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/core/SkScaledImageCache.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
7 years ago (2013-12-18 18:01:34 UTC) #1
reed1
lgtm
7 years ago (2013-12-18 18:43:27 UTC) #2
robertphillips
7 years ago (2013-12-18 18:48:30 UTC) #3
Message was sent while issue was closed.
committed as r12749

Powered by Google App Engine
This is Rietveld 408576698