Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 107443008: Revert 241548 "Chrome browser process DLL blacklist." (Closed)

Created:
7 years ago by Julien - ping for review
Modified:
7 years ago
Reviewers:
robertshield
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 241548 "Chrome browser process DLL blacklist." This is breaking the Win builders (and the blacklist_test is failing on 64 bits). > Chrome browser process DLL blacklist. > > This patch allows for blocking of module loading in the browser process. > It does not actually prevent any modules from loading. > > BUG=329023 > TEST=chrome_elf_unittests > > Review URL: https://codereview.chromium.org/107663008 TBR=robertshield@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -918 lines) Patch
M trunk/src/chrome/app/chrome_exe_main_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/chrome_exe.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/chrome_elf/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome_elf/blacklist.gypi View 1 chunk +0 lines, -60 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/blacklist.h View 1 chunk +0 lines, -52 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/blacklist.cc View 1 chunk +0 lines, -274 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/blacklist_interceptions.h View 1 chunk +0 lines, -33 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/blacklist_interceptions.cc View 1 chunk +0 lines, -226 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/test/blacklist_test.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/test/blacklist_test_dll_1.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/test/blacklist_test_dll_1.def View 1 chunk +0 lines, -5 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/test/blacklist_test_dll_2.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/test/blacklist_test_dll_2.def View 1 chunk +0 lines, -8 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/test/blacklist_test_dll_3.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/test/blacklist_test_dll_3.lib View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome_elf/blacklist/test/blacklist_test_main.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/test/blacklist_test_main_dll.h View 1 chunk +0 lines, -10 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/test/blacklist_test_main_dll.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D trunk/src/chrome_elf/blacklist/test/blacklist_test_main_dll.def View 1 chunk +0 lines, -10 lines 0 comments Download
M trunk/src/chrome_elf/chrome_elf.def View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome_elf/chrome_elf.gyp View 5 chunks +2 lines, -21 lines 0 comments Download
M trunk/src/chrome_elf/chrome_elf_main.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome_elf/chrome_elf_main.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M trunk/src/chrome_elf/version_assembly_manifest_action.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Julien - ping for review
7 years ago (2013-12-18 14:40:31 UTC) #1
Julien - ping for review
7 years ago (2013-12-18 14:40:51 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r241568.

Powered by Google App Engine
This is Rietveld 408576698