components/password_manager/core/browser/password_autofill_manager.h - Issue 1074343004: get rid of another inappropriate ToLowerASCII

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_autofill_manager.h

Issue 1074343004: get rid of another inappropriate ToLowerASCII (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nodeleteallowed

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/credit_card_unittest.cc ('k') | components/password_manager/core/browser/password_autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_autofill_manager.h

diff --git a/components/password_manager/core/browser/password_autofill_manager.h b/components/password_manager/core/browser/password_autofill_manager.h

index dfe040019d9541144d8ac4e889e8ca435ae88994..08c9842fa9a818615647b10307c3e9d493edb86a 100644

--- a/components/password_manager/core/browser/password_autofill_manager.h

+++ b/components/password_manager/core/browser/password_autofill_manager.h

@@ -35,7 +35,7 @@ class PasswordAutofillManager : public autofill::AutofillPopupDelegate {

int identifier) override;

void DidAcceptSuggestion(const base::string16& value,

int identifier) override;

- void RemoveSuggestion(const base::string16& value, int identifier) override;

+ bool RemoveSuggestion(const base::string16& value, int identifier) override;

void ClearPreviewedForm() override;

// Invoked when a password mapping is added.