Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 10743: Use the most recently used download path when displaying a "save as" dialog.... (Closed)

Created:
12 years, 1 month ago by Alex Mendes da Costa
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use the most recently used download path when displaying a "save as" dialog. Reset the download path when the user clears the download history. BUG=293 (http://code.google.com/p/chromium/issues/detail?id=293)

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M chrome/browser/browsing_data_remover.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/download/download_manager.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/download/download_manager.cc View 1 5 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alex Mendes da Costa
Hi, please review this fix for issue 293. I'm a Google employee. Do I still ...
12 years, 1 month ago (2008-11-14 07:40:09 UTC) #1
Elliot Glaysher
On 2008/11/14 07:40:09, Alex Mendes da Costa wrote: > Hi, please review this fix for ...
12 years, 1 month ago (2008-11-14 18:12:12 UTC) #2
jcampan
LGTM Jay
12 years, 1 month ago (2008-11-19 00:18:14 UTC) #3
Paul Godavari
12 years, 1 month ago (2008-11-19 00:24:50 UTC) #4
http://codereview.chromium.org/10743/diff/1/3
File chrome/browser/download/download_manager.cc (right):

http://codereview.chromium.org/10743/diff/1/3#newcode408
Line 408: // name failed.
Please line up these booleans and comments, it's horrible to read like this.

Powered by Google App Engine
This is Rietveld 408576698