Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 1074293003: Use int64 instead of int32 for response sizes. (Closed)

Created:
5 years, 8 months ago by sclittle
Modified:
5 years, 8 months ago
Reviewers:
jeremyim, bengr, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use int64 instead of int32 for response sizes. Previously, the reported size of responses larger than max int32 would overflow, and these overflowed sizes were even surfaced to UI for the Data Reduction Proxy. Verified by building Chrome with and without this patch, and using the Data Saver Chrome extension to download a 2.6 GB file. Without this patch, a negative number is shown in the Data Saver stats. With this patch, 2.6 GB is shown in the Data Saver stats. BUG=475081 Committed: https://crrev.com/b5c82196f9bb0b0033a29ff0b14553e4c2e7f41d Cr-Commit-Position: refs/heads/master@{#324738}

Patch Set 1 #

Patch Set 2 : Ran git cl format #

Patch Set 3 : Remove CHECKs #

Patch Set 4 : Reuploading to try to fix corrupt issue #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -48 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h View 1 2 chunks +7 lines, -8 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc View 1 2 chunks +19 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_job.h View 2 chunks +4 lines, -4 lines 2 comments Download

Messages

Total messages: 15 (3 generated)
sclittle
bengr: components/data_reduction_proxy/* mmenke: net/url_request/url_request_job.h Thanks in advance!
5 years, 8 months ago (2015-04-10 20:01:25 UTC) #2
mmenke
On 2015/04/10 20:01:25, sclittle wrote: > bengr: components/data_reduction_proxy/* > mmenke: net/url_request/url_request_job.h > > Thanks in ...
5 years, 8 months ago (2015-04-10 20:03:25 UTC) #3
sclittle
On 2015/04/10 20:03:25, mmenke wrote: > On 2015/04/10 20:01:25, sclittle wrote: > > bengr: components/data_reduction_proxy/* ...
5 years, 8 months ago (2015-04-10 20:09:36 UTC) #4
sclittle
On 2015/04/10 20:09:36, sclittle wrote: > On 2015/04/10 20:03:25, mmenke wrote: > > On 2015/04/10 ...
5 years, 8 months ago (2015-04-10 20:41:16 UTC) #5
mmenke
https://codereview.chromium.org/1074293003/diff/60001/net/url_request/url_request_job.h File net/url_request/url_request_job.h (right): https://codereview.chromium.org/1074293003/diff/60001/net/url_request/url_request_job.h#newcode401 net/url_request/url_request_job.h:401: int64 filter_input_byte_count_; Erm...wait...filter_input_byte_count_ and prefilter_bytes_read_ look to be identical ...
5 years, 8 months ago (2015-04-10 20:43:50 UTC) #6
sclittle
https://codereview.chromium.org/1074293003/diff/60001/net/url_request/url_request_job.h File net/url_request/url_request_job.h (right): https://codereview.chromium.org/1074293003/diff/60001/net/url_request/url_request_job.h#newcode401 net/url_request/url_request_job.h:401: int64 filter_input_byte_count_; On 2015/04/10 20:43:50, mmenke wrote: > Erm...wait...filter_input_byte_count_ ...
5 years, 8 months ago (2015-04-10 20:59:13 UTC) #7
mmenke
On 2015/04/10 20:59:13, sclittle wrote: > https://codereview.chromium.org/1074293003/diff/60001/net/url_request/url_request_job.h > File net/url_request/url_request_job.h (right): > > https://codereview.chromium.org/1074293003/diff/60001/net/url_request/url_request_job.h#newcode401 > ...
5 years, 8 months ago (2015-04-10 21:17:18 UTC) #8
sclittle
jeremyim: PTAL
5 years, 8 months ago (2015-04-10 23:04:36 UTC) #10
jeremyim
On 2015/04/10 23:04:36, sclittle wrote: > jeremyim: PTAL data_reduction_proxy LGTM
5 years, 8 months ago (2015-04-10 23:07:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074293003/60001
5 years, 8 months ago (2015-04-10 23:09:50 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-11 01:14:09 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-11 01:15:00 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b5c82196f9bb0b0033a29ff0b14553e4c2e7f41d
Cr-Commit-Position: refs/heads/master@{#324738}

Powered by Google App Engine
This is Rietveld 408576698