extensions/renderer/native_handler.h - Issue 1074273002: Move the event attach/detach logic on unload from event.js to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/native_handler.h

Issue 1074273002: Move the event attach/detach logic on unload from event.js to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: other comment Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/event_bindings.cc ('K') | « extensions/renderer/module_system_test.cc ('k') | extensions/renderer/native_handler.cc » ('j') | extensions/renderer/object_backed_native_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/native_handler.h

diff --git a/extensions/renderer/native_handler.h b/extensions/renderer/native_handler.h

index c0660c803bd7da71bc9536779c97851145cc8b10..1491feb84c3c703c710bce598dd31356a75d9741 100644

--- a/extensions/renderer/native_handler.h

+++ b/extensions/renderer/native_handler.h

@@ -29,6 +29,9 @@ class NativeHandler {

// Subclasses should override to invalidate their own V8 state. If they do

// they must call their superclass' Invalidate().

+ //

+ // Invalidate() will be called on destruction, if it hasn't already been.

Devlin 2015/04/13 16:07:07 This is not true anymore.

not at google - send to devlin 2015/04/13 17:08:30 Heh, unfortunately, it now is.

+ // Subclasses don't need to do it themselves.

virtual void Invalidate();

protected: