extensions/renderer/module_system.h - Issue 1074273002: Move the event attach/detach logic on unload from event.js to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/module_system.h

Issue 1074273002: Move the event attach/detach logic on unload from event.js to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix memory leak Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/module_system.h

diff --git a/extensions/renderer/module_system.h b/extensions/renderer/module_system.h

index 8b4a35ca45a1be49567df776c7f00924c16802c8..0b58156113f9cb06039ed29b38ad514dcf59257c 100644

--- a/extensions/renderer/module_system.h

+++ b/extensions/renderer/module_system.h

@@ -142,6 +142,7 @@ class ModuleSystem : public ObjectBackedNativeHandler,

}

protected:

+ friend class ModuleSystemTest;

friend class ScriptContext;

void Invalidate() override;

« extensions/renderer/event_bindings.cc ('K') | « extensions/renderer/event_unittest.cc ('k') | extensions/renderer/module_system.cc » ('j') | extensions/renderer/script_context.cc » ('J')