extensions/renderer/script_context_set_unittest.cc - Issue 1074273002: Move the event attach/detach logic on unload from event.js to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_context_set_unittest.cc

Issue 1074273002: Move the event attach/detach logic on unload from event.js to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: being process of relanding - more test assertions Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/script_context_set_unittest.cc

diff --git a/extensions/renderer/script_context_set_unittest.cc b/extensions/renderer/script_context_set_unittest.cc

index bf7c38d07089a7d079deb89ded27eb4d5b3e1388..cbc0a76cc77ef37fabdf07b8a14c60945b68d93f 100644

--- a/extensions/renderer/script_context_set_unittest.cc

+++ b/extensions/renderer/script_context_set_unittest.cc

@@ -53,7 +53,7 @@ TEST(ScriptContextSet, Lifecycle) {

EXPECT_EQ(1u, set_copy.size());

// After removal, the context should be marked for destruction.

- EXPECT_FALSE(context->web_frame());

+ EXPECT_FALSE(context->is_valid());

// Run loop to do the actual deletion.

loop.RunUntilIdle();

« no previous file with comments | « extensions/renderer/script_context.cc ('k') | extensions/renderer/v8_schema_registry.cc » ('j') | no next file with comments »