Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: chrome/browser/extensions/events_apitest.cc

Issue 1074273002: Move the event attach/detach logic on unload from event.js to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: being process of relanding - more test assertions Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/events_are_unregistered/manifest.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_path.h"
6 #include "base/files/file_util.h"
5 #include "chrome/browser/extensions/extension_apitest.h" 7 #include "chrome/browser/extensions/extension_apitest.h"
8 #include "extensions/browser/event_router.h"
9 #include "extensions/browser/extension_registry.h"
10
11 namespace extensions {
6 12
7 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Events) { 13 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Events) {
8 ASSERT_TRUE(RunExtensionTest("events")) << message_; 14 ASSERT_TRUE(RunExtensionTest("events")) << message_;
9 } 15 }
16
17 // Tests that events are unregistered when an extension page shuts down.
18 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, EventsAreUnregistered) {
19 // In this test, page1.html registers for a number of events, then navigates
20 // to page2.html, which should unregister those events. page2.html notifies
21 // pass, by which point the event should have been unregistered.
22 EventRouter* event_router = EventRouter::Get(profile());
23 ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
24
25 std::string test_extension_name = "events_are_unregistered";
26 ASSERT_TRUE(RunExtensionSubtest(test_extension_name, "page1.html"))
27 << message_;
28
29 // Find the extension we just installed by looking for the path.
30 base::FilePath extension_path =
31 test_data_dir_.AppendASCII(test_extension_name);
32 const Extension* extension =
33 GetExtensionByPath(registry->enabled_extensions(), extension_path);
34 ASSERT_TRUE(extension) << "No extension found at \"" << extension_path.value()
35 << "\" (absolute path \""
36 << base::MakeAbsoluteFilePath(extension_path).value()
37 << "\")";
38 const std::string& id = extension->id();
39
40 // The page has closed, so no matter what all events are no longer listened
41 // to.
42 EXPECT_FALSE(
43 event_router->ExtensionHasEventListener(id, "browserAction.onClicked"));
44 EXPECT_FALSE(
45 event_router->ExtensionHasEventListener(id, "runtime.onStartup"));
46 EXPECT_FALSE(
47 event_router->ExtensionHasEventListener(id, "runtime.onSuspend"));
48 EXPECT_FALSE(
49 event_router->ExtensionHasEventListener(id, "runtime.onInstalled"));
50 }
51
52 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/events_are_unregistered/manifest.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698