Move the event attach/detach logic on unload from event.js to

extensions/renderer/event_bindings.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_EVENT_BINDINGS_H_
 #define EXTENSIONS_RENDERER_EVENT_BINDINGS_H_
 
+#include <set>
+
 #include "extensions/renderer/object_backed_native_handler.h"
 #include "v8/include/v8.h"
 
 namespace base {
 class DictionaryValue;
 }
 
 namespace extensions {
 class Dispatcher;
 class EventFilter;

[Devlin, 2015/04/10 18:10:40]

nit: remove EventFilter* here.

[not at google - send to devlin, 2015/04/10 18:39:01]

Done.

[Devlin, 2015/04/10 22:00:24]

The star was meant to encapsulate the EventFilteringInfo, too. :)

[not at google - send to devlin, 2015/04/10 22:31:44]

Heh. I thought you just forgot to add a footnote.

 class EventFilteringInfo;
 class EventMatcher;
 
 // This class deals with the javascript bindings related to Event objects.
 class EventBindings : public ObjectBackedNativeHandler {
  public:
   EventBindings(Dispatcher* dispatcher, ScriptContext* context);
   ~EventBindings() override;
 
  private:
+  // JavaScript handler which forwards to AttachEvent().
+  // args[0] forwards to |event_name|.
+  void AttachEventHandler(const v8::FunctionCallbackInfo<v8::Value>& args);
+
   // Attach an event name to an object.
   // |event_name| The name of the event to attach.
-  void AttachEvent(const v8::FunctionCallbackInfo<v8::Value>& args);
+  void AttachEvent(const std::string& event_name);
 
-  // Detach an event name from an object.
+  // JavaScript handler which forwards to DetachEvent().
+  // args[0] forwards to |event_name|.
+  // args[1] forwards to |is_manual|.
+  void DetachEventHandler(const v8::FunctionCallbackInfo<v8::Value>& args);
+
+  // Detaches an event name from an object.
   // |event_name| The name of the event to stop listening to.
   // |is_manual| True if this detach was done by the user via removeListener()
   // as opposed to automatically during shutdown, in which case we should inform
   // the browser we are no longer interested in that event.
-  void DetachEvent(const v8::FunctionCallbackInfo<v8::Value>& args);
+  void DetachEvent(const std::string& event_name, bool is_manual);
 
   // MatcherID AttachFilteredEvent(string event_name, object filter)
   // |event_name| Name of the event to attach.
   // |filter| Which instances of the named event are we interested in.
   // returns the id assigned to the listener, which will be returned from calls
   // to MatchAgainstEventFilter where this listener matches.
   void AttachFilteredEvent(const v8::FunctionCallbackInfo<v8::Value>& args);
 
   // void DetachFilteredEvent(int id, bool manual)
   // id     - Id of the event to detach.
   // manual - false if this is part of the extension unload process where all
   //          listeners are automatically detached.
   void DetachFilteredEvent(const v8::FunctionCallbackInfo<v8::Value>& args);
 
   void MatchAgainstEventFilter(const v8::FunctionCallbackInfo<v8::Value>& args);
 
-  Dispatcher* dispatcher_;
   scoped_ptr<EventMatcher> ParseEventMatcher(
       base::DictionaryValue* filter_dict);
+
+  // Called when our context, and therefore us, is invalidated. Run any cleanup.
+  void OnInvalidated();
+
+  // The set of attached events. Maintain this so that we can detch them on
+  // unload.
+  std::set<std::string> attached_event_names_;
+
+  Dispatcher* dispatcher_;

[Devlin, 2015/04/10 18:10:40]

DISALLOW_COPY_AND_ASSIGN() (not sure why it was never added)

[not at google - send to devlin, 2015/04/10 18:39:01]

Done.

 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_EVENT_BINDINGS_H_