Chromium Code Reviews Chromium Code Reviews
Issue 1074263003:
Add histograms for a number of hacks in the HTTP header parsing logic. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@fetcher4| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 244c41c92f71bc787d1bf97d0282fc80d3ce61c4..9f605933e2c65b3a280075689c13ebeb0e108ca9 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -18627,6 +18627,15 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Net.HttpHeaderParserEvent" enum="HttpHeaderParserEvent"> |
| + <owner>mmenke@chromium.org</owner> |
| + <summary> |
| + Records the frequency of a number of hacky HTTP header parsing rules are |
| + invoked. Histogram should be removed after we have enough data to know if |
| + we can remove the hacks. |
|
Ilya Sherman
2015/04/15 00:08:06
nit: "Histogram should" -> "This histogram should"
Ilya Sherman
2015/04/15 00:08:06
nit: "frequency of" -> "frequency with which"
mmenke
2015/04/16 20:28:01
Done.
mmenke
2015/04/16 20:28:01
Done.
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="net.HttpIdentSrcURL" units="requests"> |
| <owner>tsepez@chromium.org</owner> |
| <summary> |
| @@ -52496,6 +52505,14 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| <int value="15" label="Negotiate Secure Server"/> |
| </enum> |
| +<enum name="HttpHeaderParserEvent" type="int"> |
| + <int value="0" label="PARSER_INVOKED"/> |
| + <int value="1" label="HTTP_09_RESPONSE"/> |
| + <int value="2" label="ALLOWED_TRUNCATED_HEADERS"/> |
| + <int value="3" label="SKIPPED_WS_PREFIX"/> |
| + <int value="4" label="SKIPPED_NON_WS_PREFIX"/> |
| +</enum> |
| + |
| <enum name="HttpPipelineStatus" type="int"> |
| <int value="0" label="Success"/> |
| <int value="1" label="Redirected"/> |
