tools/metrics/histograms/histograms.xml - Issue 1074263003: Add histograms for a number of hacks in the HTTP header parsing logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1074263003: Add histograms for a number of hacks in the HTTP header parsing logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fetcher4

Patch Set: Response to comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 244c41c92f71bc787d1bf97d0282fc80d3ce61c4..bed1cf4f1fae56aab00c61943bd8b63b5144d27d 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -18627,6 +18627,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="Net.HttpHeaderParserEvent" enum="HttpHeaderParserEvent">

+ <owner>mmenke@chromium.org</owner>

+ <summary>

+ Records the frequency with which a number of hacky HTTP header parsing rules

+ are invoked. This histogram should be removed after we have enough data to

+ know if we can remove the hacks.

+ </summary>

+</histogram>

<owner>tsepez@chromium.org</owner>

@@ -52496,6 +52505,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</enum>

+<enum name="HttpHeaderParserEvent" type="int">

+ <int value="0" label="PARSER_INVOKED"/>

+ <int value="1" label="HTTP_09_RESPONSE"/>

+ <int value="2" label="ALLOWED_TRUNCATED_HEADERS"/>

+ <int value="3" label="SKIPPED_WS_PREFIX"/>

+ <int value="4" label="SKIPPED_NON_WS_PREFIX"/>

+</enum>

« no previous file with comments | « net/http/http_stream_parser.cc ('k') | no next file » | no next file with comments »