Issue 1074253002: Adjust Subzero CMAKE=1 build to also use libc++ (like autoconf).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1074253002: Adjust Subzero CMAKE=1 build to also use libc++ (like autoconf). (Closed)

Created:
5 years, 8 months ago by jvoung (off chromium)

Modified:
5 years, 8 months ago

Reviewers:
Karl, Jim Stichnoth, Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Adjust Subzero CMAKE=1 build to also use libc++ (like autoconf). This is to go with toolchain_build changes which make LLVM cmake also use libc++: https://codereview.chromium.org/978963002/ May help with the memory sanitizer build, which wants most code to be built with memory sanitizer (e.g., make a special build of libc++). BUG= https://code.google.com/p/nativeclient/issues/detail?id=4119 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d8fb3d33f38258b7fb177bd4cb420fab2e0c2c3a

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	Makefile.standalone	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

jvoung (off chromium)

5 years, 8 months ago (2015-04-10 17:50:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d8fb3d33f38258b7fb177bd4cb420fab2e0c2c3a (presubmit successful).